Re: [HACKERS] interface libpq Makefile.in patch

Hello Hackers ...

The following patch is needed to compile the current development tree with perl
support. The addition of MemoryContextAlloc, MemoryContextFree, and
MemoryContexRealloc in ./src/include/utils/palloc.h require these additional
header files.

Also where is the current TODO list, I'd like to pick a small project and help
out when I can.

Thanks,
-Ryan

P.S.

If I created this patch wrong, or I posted it to the wrong place let me know and
I'll correct it next time.

*** ./src/interfaces/libpq/Makefile.in.orig Wed Feb 10 19:11:55 1999
--- ./src/interfaces/libpq/Makefile.in Wed Feb 10 19:09:25 1999
***************
*** 106,121 ****
$(HEADERDIR)/utils/elog.h
$(INSTALL) $(INSTLOPTS) $(SRCDIR)/include/utils/palloc.h \
$(HEADERDIR)/utils/palloc.h
- $(INSTALL) $(INSTLOPTS) $(SRCDIR)/include/utils/mcxt.h \
- $(HEADERDIR)/utils/mcxt.h
- $(INSTALL) $(INSTLOPTS) $(SRCDIR)/include/nodes/memnodes.h \
- $(HEADERDIR)/nodes/memnodes.h
- $(INSTALL) $(INSTLOPTS) $(SRCDIR)/include/nodes/nodes.h \
- $(HEADERDIR)/nodes/nodes.h
- $(INSTALL) $(INSTLOPTS) $(SRCDIR)/include/lib/fstack.h \
- $(HEADERDIR)/lib/fstack.h
- $(INSTALL) $(INSTLOPTS) $(SRCDIR)/include/utils/memutils.h \
- $(HEADERDIR)/utils/memutils.h
$(INSTALL) $(INSTLOPTS) $(SRCDIR)/include/access/attnum.h \
$(HEADERDIR)/access/attnum.h
$(INSTALL) $(INSTLOPTS) $(SRCDIR)/include/executor/spi.h \
--- 106,111 ----
***************
*** 139,146 ****
@if [ ! -d $(HEADERDIR)/libpq ]; \
then mkdir $(HEADERDIR)/libpq; fi
@if [ ! -d $(HEADERDIR)/utils ]; \
- then mkdir $(HEADERDIR)/nodes; fi
- @if [ ! -d $(HEADERDIR)/nodes ]; \
then mkdir $(HEADERDIR)/utils; fi
@if [ ! -d $(HEADERDIR)/access ]; \
then mkdir $(HEADERDIR)/access; fi
--- 129,134 ----

See the /doc directory or the web site under Support.

> Hello Hackers ...
>
> The following patch is needed to compile the current development tree with perl
> support. The addition of MemoryContextAlloc, MemoryContextFree, and
> MemoryContexRealloc in ./src/include/utils/palloc.h require these additional
> header files.
>
> Also where is the current TODO list, I'd like to pick a small project and help
> out when I can.
>
> Thanks,
> -Ryan
>
> P.S.
>
> If I created this patch wrong, or I posted it to the wrong place let me know and
> I'll correct it next time.
>
> *** ./src/interfaces/libpq/Makefile.in.orig Wed Feb 10 19:11:55 1999
> --- ./src/interfaces/libpq/Makefile.in Wed Feb 10 19:09:25 1999
> ***************
> *** 106,121 ****
> $(HEADERDIR)/utils/elog.h
> $(INSTALL) $(INSTLOPTS) $(SRCDIR)/include/utils/palloc.h \
> $(HEADERDIR)/utils/palloc.h
> - $(INSTALL) $(INSTLOPTS) $(SRCDIR)/include/utils/mcxt.h \
> - $(HEADERDIR)/utils/mcxt.h
> - $(INSTALL) $(INSTLOPTS) $(SRCDIR)/include/nodes/memnodes.h \
> - $(HEADERDIR)/nodes/memnodes.h
> - $(INSTALL) $(INSTLOPTS) $(SRCDIR)/include/nodes/nodes.h \
> - $(HEADERDIR)/nodes/nodes.h
> - $(INSTALL) $(INSTLOPTS) $(SRCDIR)/include/lib/fstack.h \
> - $(HEADERDIR)/lib/fstack.h
> - $(INSTALL) $(INSTLOPTS) $(SRCDIR)/include/utils/memutils.h \
> - $(HEADERDIR)/utils/memutils.h
> $(INSTALL) $(INSTLOPTS) $(SRCDIR)/include/access/attnum.h \
> $(HEADERDIR)/access/attnum.h
> $(INSTALL) $(INSTLOPTS) $(SRCDIR)/include/executor/spi.h \
> --- 106,111 ----
> ***************
> *** 139,146 ****
> @if [ ! -d $(HEADERDIR)/libpq ]; \
> then mkdir $(HEADERDIR)/libpq; fi
> @if [ ! -d $(HEADERDIR)/utils ]; \
> - then mkdir $(HEADERDIR)/nodes; fi
> - @if [ ! -d $(HEADERDIR)/nodes ]; \
> then mkdir $(HEADERDIR)/utils; fi
> @if [ ! -d $(HEADERDIR)/access ]; \
> then mkdir $(HEADERDIR)/access; fi
> --- 129,134 ----
>
>
>

--
Bruce Momjian | http://www.op.net/~candle
maillist(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

Ryan Bradetich <rbrad(at)hpb50023(dot)boi(dot)hp(dot)com> writes:
> The following patch is needed to compile the current development tree
> with perl support. The addition of MemoryContextAlloc,
> MemoryContextFree, and MemoryContexRealloc in
> ./src/include/utils/palloc.h require these additional header files.

Something wrong here ... palloc should not be visible outside the
backend. libpq used to have vestigial dependencies on some backend
header files, but I thought I'd got rid of them.

I have not compiled the perl module in a while; I'll check this.

regards, tom lane

On Thu, Feb 11, 1999 at 12:18:06AM -0500, Tom Lane wrote:
> Ryan Bradetich <rbrad(at)hpb50023(dot)boi(dot)hp(dot)com> writes:
> > The following patch is needed to compile the current development tree
> > with perl support. The addition of MemoryContextAlloc,
> > MemoryContextFree, and MemoryContexRealloc in
> > ./src/include/utils/palloc.h require these additional header files.
>
> Something wrong here ... palloc should not be visible outside the
> backend. libpq used to have vestigial dependencies on some backend
> header files, but I thought I'd got rid of them.
>
> I have not compiled the perl module in a while; I'll check this.

They are back in. And even worse palloc.h include mcxt.h and this one isn't
even installed.

Michael
--
Michael Meskes | Go SF 49ers!
Th.-Heuss-Str. 61, D-41812 Erkelenz | Go Rhein Fire!
Tel.: (+49) 2431/72651 | Use Debian GNU/Linux!
Email: Michael(dot)Meskes(at)gmx(dot)net | Use PostgreSQL!