Documentation issue

Lists: pgsql-general
From: salah jubeh <s_jubeh(at)yahoo(dot)com>
To: pgsql <pgsql-general(at)postgresql(dot)org>
Subject: Documentation issue
Date: 2011-07-07 13:56:12
Message-ID: 1310046972.61619.YahooMailRC@web161511.mail.bf1.yahoo.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-general

Hello,

In http://www.postgresql.org/docs/8.4/static/xfunc-c.html, there is a missing
include to the utils/geo_decls.h which leads to compilation errors. i.e #include
"utils/geo_decls.h"
needs to be added to the code.

Kind regards


From: Bruce Momjian <bruce(at)momjian(dot)us>
To: salah jubeh <s_jubeh(at)yahoo(dot)com>
Cc: pgsql <pgsql-general(at)postgresql(dot)org>
Subject: Re: Documentation issue
Date: 2011-07-18 20:58:19
Message-ID: 201107182058.p6IKwJh25823@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-general

salah jubeh wrote:
> Hello,
>
> In http://www.postgresql.org/docs/8.4/static/xfunc-c.html, there is a missing
> include to the utils/geo_decls.h which leads to compilation errors. i.e #include
> "utils/geo_decls.h"
> needs to be added to the code.

Uh, which function sample is missing it?

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +


From: salah jubeh <s_jubeh(at)yahoo(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: pgsql <pgsql-general(at)postgresql(dot)org>
Subject: Re: Documentation issue
Date: 2011-07-18 21:02:43
Message-ID: 1311022963.2636.YahooMailRC@web161519.mail.bf1.yahoo.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-general

#include "postgres.h" #include <string.h> #include "fmgr.h" /* by value */
PG_FUNCTION_INFO_V1(add_one); Datum add_one(PG_FUNCTION_ARGS) { int32 arg
= PG_GETARG_INT32(0);

....

Best Regard

Eng. Salah Al Jubeh

PalestinePolytechnic University
College of Applied Science
Computer Science
P.O. Box 198

Mobile:++97259369122
Tel:++97222254680

________________________________
From: Bruce Momjian <bruce(at)momjian(dot)us>
To: salah jubeh <s_jubeh(at)yahoo(dot)com>
Cc: pgsql <pgsql-general(at)postgresql(dot)org>
Sent: Mon, July 18, 2011 10:58:19 PM
Subject: Re: [GENERAL] Documentation issue

salah jubeh wrote:
> Hello,
>
> In http://www.postgresql.org/docs/8.4/static/xfunc-c.html, there is a missing
> include to the utils/geo_decls.h which leads to compilation errors. i.e
>#include
>
> "utils/geo_decls.h"
> needs to be added to the code.

Uh, which function sample is missing it?

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +


From: Bruce Momjian <bruce(at)momjian(dot)us>
To: salah jubeh <s_jubeh(at)yahoo(dot)com>
Cc: pgsql <pgsql-general(at)postgresql(dot)org>
Subject: Re: Documentation issue
Date: 2011-07-18 21:09:37
Message-ID: 201107182109.p6IL9bb27425@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-general

salah jubeh wrote:
> #include "postgres.h" #include <string.h> #include "fmgr.h" /* by value */
> PG_FUNCTION_INFO_V1(add_one); Datum add_one(PG_FUNCTION_ARGS) { int32 arg
> = PG_GETARG_INT32(0);

Great, this was fixed in Postgres 9.0. You can see it here:

http://www.postgresql.org/docs/9.0/static/xfunc-c.html

#include "postgres.h"
#include <string.h>
#include "utils/geo_decls.h"

#ifdef PG_MODULE_MAGIC
PG_MODULE_MAGIC;
#endif

/* by value */

int
add_one(int arg)

---------------------------------------------------------------------------

>
> ....
>
>
> Best Regard
>
> Eng. Salah Al Jubeh
>
> PalestinePolytechnic University
> College of Applied Science
> Computer Science
> P.O. Box 198
>
> Mobile:++97259369122
> Tel:++97222254680
>
>
>
>
>
>
>
> ________________________________
> From: Bruce Momjian <bruce(at)momjian(dot)us>
> To: salah jubeh <s_jubeh(at)yahoo(dot)com>
> Cc: pgsql <pgsql-general(at)postgresql(dot)org>
> Sent: Mon, July 18, 2011 10:58:19 PM
> Subject: Re: [GENERAL] Documentation issue
>
> salah jubeh wrote:
> > Hello,
> >
> > In http://www.postgresql.org/docs/8.4/static/xfunc-c.html, there is a missing
> > include to the utils/geo_decls.h which leads to compilation errors. i.e
> >#include
> >
> > "utils/geo_decls.h"
> > needs to be added to the code.
>
> Uh, which function sample is missing it?
>
> --
> Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
> EnterpriseDB http://enterprisedb.com
>
> + It's impossible for everything to be true. +
>
> --
> Sent via pgsql-general mailing list (pgsql-general(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-general

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +


From: salah jubeh <s_jubeh(at)yahoo(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: pgsql <pgsql-general(at)postgresql(dot)org>
Subject: Re: Documentation issue
Date: 2011-07-18 21:13:27
Message-ID: 1311023607.912.YahooMailRC@web161517.mail.bf1.yahoo.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-general

Hello Bruce,

Indeed; However, it would be nice to update also the documentation in 8.4 it
will not take a lot of effort -:)

Best Regard

Eng. Salah Al Jubeh

PalestinePolytechnic University
College of Applied Science
Computer Science
P.O. Box 198

Mobile:++97259369122
Tel:++97222254680

________________________________
From: Bruce Momjian <bruce(at)momjian(dot)us>
To: salah jubeh <s_jubeh(at)yahoo(dot)com>
Cc: pgsql <pgsql-general(at)postgresql(dot)org>
Sent: Mon, July 18, 2011 11:09:37 PM
Subject: Re: [GENERAL] Documentation issue

salah jubeh wrote:
> #include "postgres.h" #include <string.h> #include "fmgr.h" /* by value */
> PG_FUNCTION_INFO_V1(add_one); Datum add_one(PG_FUNCTION_ARGS) { int32
>arg
>
> = PG_GETARG_INT32(0);

Great, this was fixed in Postgres 9.0. You can see it here:

http://www.postgresql.org/docs/9.0/static/xfunc-c.html

#include "postgres.h"
#include <string.h>
#include "utils/geo_decls.h"

#ifdef PG_MODULE_MAGIC
PG_MODULE_MAGIC;
#endif

/* by value */

int
add_one(int arg)

---------------------------------------------------------------------------

>
> ....
>
>
> Best Regard
>
> Eng. Salah Al Jubeh
>
> PalestinePolytechnic University
> College of Applied Science
> Computer Science
> P.O. Box 198
>
> Mobile:++97259369122
> Tel:++97222254680
>
>
>
>
>
>
>
> ________________________________
> From: Bruce Momjian <bruce(at)momjian(dot)us>
> To: salah jubeh <s_jubeh(at)yahoo(dot)com>
> Cc: pgsql <pgsql-general(at)postgresql(dot)org>
> Sent: Mon, July 18, 2011 10:58:19 PM
> Subject: Re: [GENERAL] Documentation issue
>
> salah jubeh wrote:
> > Hello,
> >
> > In http://www.postgresql.org/docs/8.4/static/xfunc-c.html, there is a missing
>
> > include to the utils/geo_decls.h which leads to compilation errors. i.e
> >#include
> >
> > "utils/geo_decls.h"
> > needs to be added to the code.
>
> Uh, which function sample is missing it?
>
> --
> Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
> EnterpriseDB http://enterprisedb.com
>
> + It's impossible for everything to be true. +
>
> --
> Sent via pgsql-general mailing list (pgsql-general(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-general

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +


From: Bruce Momjian <bruce(at)momjian(dot)us>
To: salah jubeh <s_jubeh(at)yahoo(dot)com>
Cc: pgsql <pgsql-general(at)postgresql(dot)org>
Subject: Re: Documentation issue
Date: 2011-07-18 21:25:28
Message-ID: 201107182125.p6ILPSH29119@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-general

salah jubeh wrote:
> Hello Bruce,
>
> Indeed; However, it would be nice to update also the documentation in 8.4 it
> will not take a lot of effort -:)

Uh, we don't normally backpatch such things. Sorry.

---------------------------------------------------------------------------

>
>
> Best Regard
>
> Eng. Salah Al Jubeh
>
> PalestinePolytechnic University
> College of Applied Science
> Computer Science
> P.O. Box 198
>
> Mobile:++97259369122
> Tel:++97222254680
>
>
>
>
>
>
>
> ________________________________
> From: Bruce Momjian <bruce(at)momjian(dot)us>
> To: salah jubeh <s_jubeh(at)yahoo(dot)com>
> Cc: pgsql <pgsql-general(at)postgresql(dot)org>
> Sent: Mon, July 18, 2011 11:09:37 PM
> Subject: Re: [GENERAL] Documentation issue
>
> salah jubeh wrote:
> > #include "postgres.h" #include <string.h> #include "fmgr.h" /* by value */
> > PG_FUNCTION_INFO_V1(add_one); Datum add_one(PG_FUNCTION_ARGS) { int32
> >arg
> >
> > = PG_GETARG_INT32(0);
>
> Great, this was fixed in Postgres 9.0. You can see it here:
>
> http://www.postgresql.org/docs/9.0/static/xfunc-c.html
>
> #include "postgres.h"
> #include <string.h>
> #include "utils/geo_decls.h"
>
> #ifdef PG_MODULE_MAGIC
> PG_MODULE_MAGIC;
> #endif
>
> /* by value */
>
> int
> add_one(int arg)
>
> ---------------------------------------------------------------------------
>
>
> >
> > ....
> >
> >
> > Best Regard
> >
> > Eng. Salah Al Jubeh
> >
> > PalestinePolytechnic University
> > College of Applied Science
> > Computer Science
> > P.O. Box 198
> >
> > Mobile:++97259369122
> > Tel:++97222254680
> >
> >
> >
> >
> >
> >
> >
> > ________________________________
> > From: Bruce Momjian <bruce(at)momjian(dot)us>
> > To: salah jubeh <s_jubeh(at)yahoo(dot)com>
> > Cc: pgsql <pgsql-general(at)postgresql(dot)org>
> > Sent: Mon, July 18, 2011 10:58:19 PM
> > Subject: Re: [GENERAL] Documentation issue
> >
> > salah jubeh wrote:
> > > Hello,
> > >
> > > In http://www.postgresql.org/docs/8.4/static/xfunc-c.html, there is a missing
> >
> > > include to the utils/geo_decls.h which leads to compilation errors. i.e
> > >#include
> > >
> > > "utils/geo_decls.h"
> > > needs to be added to the code.
> >
> > Uh, which function sample is missing it?
> >
> > --
> > Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
> > EnterpriseDB http://enterprisedb.com
> >
> > + It's impossible for everything to be true. +
> >
> > --
> > Sent via pgsql-general mailing list (pgsql-general(at)postgresql(dot)org)
> > To make changes to your subscription:
> > http://www.postgresql.org/mailpref/pgsql-general
>
> --
> Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
> EnterpriseDB http://enterprisedb.com
>
> + It's impossible for everything to be true. +
>
> --
> Sent via pgsql-general mailing list (pgsql-general(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-general

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +