Re: HTML tags :/

Lists: pgsql-hackers
From: David Fetter <david(at)fetter(dot)org>
To: PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: HTML tags :/
Date: 2011-04-18 21:34:11
Message-ID: 20110418213411.GC27115@fetter.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Folks,

While readjusting pg_docbot's URLs for LEAST and GREATEST, I came
across an infelicity. They'd been tagged as
"http://www.postgresql.org/docs/current/static/functions-conditional.html#AEN12680"
and I re-tagged them as
"http://www.postgresql.org/docs/current/static/functions-conditional.html#AEN15582"

I didn't see a more descriptive tag. Am I missing something
important?

Cheers,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate


From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: David Fetter <david(at)fetter(dot)org>
Cc: PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: HTML tags :/
Date: 2011-04-18 21:44:03
Message-ID: 1303162836-sup-132@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Excerpts from David Fetter's message of lun abr 18 18:34:11 -0300 2011:
> Folks,
>
> While readjusting pg_docbot's URLs for LEAST and GREATEST, I came
> across an infelicity. They'd been tagged as
> "http://www.postgresql.org/docs/current/static/functions-conditional.html#AEN12680"
> and I re-tagged them as
> "http://www.postgresql.org/docs/current/static/functions-conditional.html#AEN15582"
>
> I didn't see a more descriptive tag. Am I missing something
> important?

The sect2 they are in would need an id attribute for there to be a
stable #-style link.

--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support


From: David Fetter <david(at)fetter(dot)org>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: HTML tags :/
Date: 2011-05-02 13:58:37
Message-ID: 20110502135837.GA8003@fetter.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Mon, Apr 18, 2011 at 06:44:03PM -0300, Alvaro Herrera wrote:
> Excerpts from David Fetter's message of lun abr 18 18:34:11 -0300 2011:
> > Folks,
> >
> > While readjusting pg_docbot's URLs for LEAST and GREATEST, I came
> > across an infelicity. They'd been tagged as
> > "http://www.postgresql.org/docs/current/static/functions-conditional.html#AEN12680"
> > and I re-tagged them as
> > "http://www.postgresql.org/docs/current/static/functions-conditional.html#AEN15582"
> >
> > I didn't see a more descriptive tag. Am I missing something
> > important?
>
> The sect2 they are in would need an id attribute for there to be a
> stable #-style link.

Please find attached a patch to fix this.

I believe there are other places in the docs where an id attribute
would be handy. Will check those :)

Cheers,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

Attachment Content-Type Size
tag_least_greatest.diff text/plain 369 bytes

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: David Fetter <david(at)fetter(dot)org>
Cc: PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: HTML tags :/
Date: 2011-05-02 15:15:09
Message-ID: 1304349262-sup-4115@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Excerpts from David Fetter's message of lun may 02 10:58:37 -0300 2011:
> On Mon, Apr 18, 2011 at 06:44:03PM -0300, Alvaro Herrera wrote:

> > The sect2 they are in would need an id attribute for there to be a
> > stable #-style link.
>
> Please find attached a patch to fix this.
>
> I believe there are other places in the docs where an id attribute
> would be handy. Will check those :)

I think it'd be good to have id attrs in all the sect2 sections of that
chapter.

--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support


From: David Fetter <david(at)fetter(dot)org>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: HTML tags :/
Date: 2011-05-02 17:30:15
Message-ID: 20110502173015.GA20348@fetter.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Mon, May 02, 2011 at 12:15:09PM -0300, Alvaro Herrera wrote:
> Excerpts from David Fetter's message of lun may 02 10:58:37 -0300 2011:
> > On Mon, Apr 18, 2011 at 06:44:03PM -0300, Alvaro Herrera wrote:
>
> > > The sect2 they are in would need an id attribute for there to be a
> > > stable #-style link.
> >
> > Please find attached a patch to fix this.
> >
> > I believe there are other places in the docs where an id attribute
> > would be handy. Will check those :)
>
> I think it'd be good to have id attrs in all the sect2 sections of that
> chapter.

By "that chapter," do you mean everything in func.sgml, or just the
stuff in the <sect1 id="functions-conditional"> ?

Cheers,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate


From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: David Fetter <david(at)fetter(dot)org>
Cc: PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: HTML tags :/
Date: 2011-05-02 19:56:42
Message-ID: 1304366010-sup-1990@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Excerpts from David Fetter's message of lun may 02 14:30:15 -0300 2011:
> On Mon, May 02, 2011 at 12:15:09PM -0300, Alvaro Herrera wrote:

> > I think it'd be good to have id attrs in all the sect2 sections of that
> > chapter.
>
> By "that chapter," do you mean everything in func.sgml, or just the
> stuff in the <sect1 id="functions-conditional"> ?

Well, I mean the chapter:

<chapter id="functions">

There aren't that many sect2's missing the id (about one third of them
are in functions-conditional). The ones in functions-subquery could be
problematic though.

--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support


From: David Fetter <david(at)fetter(dot)org>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: HTML tags :/
Date: 2011-05-02 20:53:35
Message-ID: 20110502205335.GA4741@fetter.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Mon, May 02, 2011 at 04:56:42PM -0300, Alvaro Herrera wrote:
> Excerpts from David Fetter's message of lun may 02 14:30:15 -0300 2011:
> > On Mon, May 02, 2011 at 12:15:09PM -0300, Alvaro Herrera wrote:
>
> > > I think it'd be good to have id attrs in all the sect2 sections of that
> > > chapter.
> >
> > By "that chapter," do you mean everything in func.sgml, or just the
> > stuff in the <sect1 id="functions-conditional"> ?
>
> Well, I mean the chapter:
>
> <chapter id="functions">
>
> There aren't that many sect2's missing the id (about one third of them
> are in functions-conditional). The ones in functions-subquery could be
> problematic though.

Please find attached a patch adding IDs to the appropriate (I think)
spots.

Cheers,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

Attachment Content-Type Size
tag_least_greatest_02.diff text/plain 2.6 KB

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: David Fetter <david(at)fetter(dot)org>
Cc: PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: HTML tags :/
Date: 2011-05-03 12:38:40
Message-ID: 1304426200-sup-9806@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Excerpts from David Fetter's message of lun may 02 17:53:35 -0300 2011:

> Please find attached a patch adding IDs to the appropriate (I think)
> spots.

Thanks. There are some ID missing on some sect2 still; I had a look
yesterday and the problem is that the subsection titles collide with the
sect2 titles of the previous sect1, which makes choosing good names not
so trivial.

I also tried to backpatch this to 9.0 but it doesn't apply cleanly so I
left it alone. If you want it to be backpatched, please send a modified
patch.

--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support