| Lists: | pgsql-committerspgsql-hackers |
|---|
| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: Separate messages for standby replies and hot standby feedback. |
| Date: | 2011-02-18 11:34:05 |
| Message-ID: | E1PqOb7-0003tv-2e@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-committers pgsql-hackers |
Separate messages for standby replies and hot standby feedback.
Allow messages to be sent at different times, and greatly reduce
the frequency of hot standby feedback. Refactor to allow additional
message types.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/06828c5febf3a8f9e94bce5bd84634ce990d299f
Modified Files
--------------
src/backend/replication/walreceiver.c | 104 ++++++++++++++++++++--------
src/backend/replication/walsender.c | 124 +++++++++++++++++++++------------
src/include/replication/walprotocol.h | 15 ++++-
3 files changed, 168 insertions(+), 75 deletions(-)
| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [COMMITTERS] pgsql: Separate messages for standby replies and hot standby feedback. |
| Date: | 2011-02-18 12:11:01 |
| Message-ID: | AANLkTikoCWqhUnoCsOXmUZUcK0WcWLJMfg8=9HmuBR80@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-committers pgsql-hackers |
On Fri, Feb 18, 2011 at 6:34 AM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> Separate messages for standby replies and hot standby feedback.
> Allow messages to be sent at different times, and greatly reduce
> the frequency of hot standby feedback. Refactor to allow additional
> message types.
You could refactor this some more to avoid calling
GetCurrentTimestamp() and TimestampDifferenceExceeds() twice each, but
I'm not sure whether it's worth it.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [COMMITTERS] pgsql: Separate messages for standby replies and hot standby feedback. |
| Date: | 2011-02-18 14:28:26 |
| Message-ID: | 1298039306.2226.4834.camel@ebony |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-committers pgsql-hackers |
On Fri, 2011-02-18 at 07:11 -0500, Robert Haas wrote:
> On Fri, Feb 18, 2011 at 6:34 AM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> > Separate messages for standby replies and hot standby feedback.
> > Allow messages to be sent at different times, and greatly reduce
> > the frequency of hot standby feedback. Refactor to allow additional
> > message types.
>
> You could refactor this some more to avoid calling
> GetCurrentTimestamp() and TimestampDifferenceExceeds() twice each, but
> I'm not sure whether it's worth it.
Thanks for the observation.
--
Simon Riggs http://www.2ndQuadrant.com/books/
PostgreSQL Development, 24x7 Support, Training and Services
| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
|---|---|
| To: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Separate messages for standby replies and hot standby feedback. |
| Date: | 2011-02-18 18:22:37 |
| Message-ID: | 4D5EB8ED.7010002@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-committers pgsql-hackers |
On 18.02.2011 13:34, Simon Riggs wrote:
> Separate messages for standby replies and hot standby feedback.
> Allow messages to be sent at different times, and greatly reduce
> the frequency of hot standby feedback. Refactor to allow additional
> message types.
Please update the docs too, these messages are briefly explained at
http://developer.postgresql.org/pgdocs/postgres/protocol-replication.html
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Separate messages for standby replies and hot standby feedback. |
| Date: | 2011-02-18 19:07:25 |
| Message-ID: | 1298056045.2226.5314.camel@ebony |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-committers pgsql-hackers |
On Fri, 2011-02-18 at 20:22 +0200, Heikki Linnakangas wrote:
> On 18.02.2011 13:34, Simon Riggs wrote:
> > Separate messages for standby replies and hot standby feedback.
> > Allow messages to be sent at different times, and greatly reduce
> > the frequency of hot standby feedback. Refactor to allow additional
> > message types.
>
> Please update the docs too, these messages are briefly explained at
> http://developer.postgresql.org/pgdocs/postgres/protocol-replication.html
Hadn't forgotten, just working thru things in priority order.
--
Simon Riggs http://www.2ndQuadrant.com/books/
PostgreSQL Development, 24x7 Support, Training and Services
| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
| Cc: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Separate messages for standby replies and hot standby feedback. |
| Date: | 2011-02-18 19:12:51 |
| Message-ID: | AANLkTiktg1gNAmnj_FgbmRpHqz1bEvbrpCYw_5SWd7L+@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-committers pgsql-hackers |
On Fri, Feb 18, 2011 at 2:07 PM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> On Fri, 2011-02-18 at 20:22 +0200, Heikki Linnakangas wrote:
>> On 18.02.2011 13:34, Simon Riggs wrote:
>> > Separate messages for standby replies and hot standby feedback.
>> > Allow messages to be sent at different times, and greatly reduce
>> > the frequency of hot standby feedback. Refactor to allow additional
>> > message types.
>>
>> Please update the docs too, these messages are briefly explained at
>> http://developer.postgresql.org/pgdocs/postgres/protocol-replication.html
>
> Hadn't forgotten, just working thru things in priority order.
Updating the documentation is surely not a low-priority item.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company