Re: [COMMITTERS] pgsql: Adjust pg_upgrade error message, array freeing, and add error ch

Lists: pgsql-committerspgsql-hackers
From: Bruce Momjian <bruce(at)momjian(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Adjust pg_upgrade error message, array freeing, and add error ch
Date: 2011-02-15 20:00:49
Message-ID: E1PpR4r-00070F-3a@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers pgsql-hackers

Adjust pg_upgrade error message, array freeing, and add error check.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/fe8f15d5d2f42ad1ce6a0114c12fd3da0f14dd4a

Modified Files
--------------
contrib/pg_upgrade/check.c | 2 --
contrib/pg_upgrade/info.c | 9 +++++++++
contrib/pg_upgrade/pg_upgrade.c | 1 -
contrib/pg_upgrade/relfilenode.c | 2 +-
4 files changed, 10 insertions(+), 4 deletions(-)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Adjust pg_upgrade error message, array freeing, and add error ch
Date: 2011-02-15 21:05:59
Message-ID: 10460.1297803959@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers pgsql-hackers

Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Adjust pg_upgrade error message, array freeing, and add error check.

The buildfarm says this patch is broken.

regards, tom lane

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Adjust pg_upgrade error message, array freeing, and add error ch
Date: 2011-02-15 23:00:39
Message-ID: 1297810534-sup-4626@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers pgsql-hackers

Excerpts from Tom Lane's message of mar feb 15 18:05:59 -0300 2011:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > Adjust pg_upgrade error message, array freeing, and add error check.
>
> The buildfarm says this patch is broken.

I have just pushed a fix for this. It's probably not the prettiest
thing in the world, but there doesn't seem to be a place where the
ClusterInfo structs are initialized. Maybe that merits more cleanup,
not sure.

--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Adjust pg_upgrade error message, array freeing, and add error ch
Date: 2011-02-16 01:53:03
Message-ID: 201102160153.p1G1r3s14199@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers pgsql-hackers

Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > Adjust pg_upgrade error message, array freeing, and add error check.
>
> The buildfarm says this patch is broken.

Thanks, fixed a few hours ago.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +