| Lists: | pgsql-hackers |
|---|
| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | EXPLAIN Sort Method whitespace |
| Date: | 2010-12-04 16:21:55 |
| Message-ID: | 1291479715.3568.6.camel@vanquo.pezone.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Is there a reason why there are two spaces after the first colon in
"Sort Method: %s %s: %ldkB\n"
Is the second part (Disk/Memory) considered part of the sort method?
The original commit for that is d2a4a406.
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: EXPLAIN Sort Method whitespace |
| Date: | 2010-12-04 17:08:27 |
| Message-ID: | 24298.1291482507@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> Is there a reason why there are two spaces after the first colon in
> "Sort Method: %s %s: %ldkB\n"
> Is the second part (Disk/Memory) considered part of the sort method?
I think of it as a separate field that we cram onto the same line (in
the textual output format) for space reasons. In the machine-readable
formats it's definitely separate.
I agree it seems a bit inconsistent that there are two spaces after
one colon and only one after the other. I must have thought it was
a good idea at the time, but now I don't remember why. Since we
don't seem to put two spaces after any other colon in text format,
maybe
"Sort Method: %s %s: %ldkB\n"
would be better. Is that what you were thinking?
regards, tom lane