| Lists: | pgsql-hackers |
|---|
| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | signal and startup process |
| Date: | 2010-10-14 03:57:52 |
| Message-ID: | AANLkTi=aHWc0=rOgtJvwkc5=1y5e2MciXNa=D=LOW6wr@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Hi,
It takes nonsensically extra several seconds to shut down the standby server.
This is because the startup process cannot respond immediately the SIGTERM
signal sent by postmaster for the shutdown while it's sleeping on WaitLatch.
This delays the shutdown for up to the sleep time on WaitLatch (currently
5 seconds).
The signal handlers of the startup process should call SetLatch to respond
the signals even while it's sleeping on WaitLatch, like those of walsender
already do. The attached patch does this.
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
| Attachment | Content-Type | Size |
|---|---|---|
| signal_handler_wakeup_recovery_v1.patch | application/octet-stream | 528 bytes |
| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: signal and startup process |
| Date: | 2010-10-14 18:17:58 |
| Message-ID: | 1287080278.1725.1092.camel@ebony |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Committed.
On Thu, 2010-10-14 at 12:57 +0900, Fujii Masao wrote:
> Hi,
>
> It takes nonsensically extra several seconds to shut down the standby server.
> This is because the startup process cannot respond immediately the SIGTERM
> signal sent by postmaster for the shutdown while it's sleeping on WaitLatch.
> This delays the shutdown for up to the sleep time on WaitLatch (currently
> 5 seconds).
>
> The signal handlers of the startup process should call SetLatch to respond
> the signals even while it's sleeping on WaitLatch, like those of walsender
> already do. The attached patch does this.
>
> Regards,
>
--
Simon Riggs www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Training and Services