| Lists: | pgsql-hackers |
|---|
| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | make everything target |
| Date: | 2010-01-27 15:41:16 |
| Message-ID: | 4B605E9C.6010504@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
I'd like to have an "everything" target that would build "all + html +
contrib".
And maybe an "installcheck-everything" target that would run
installcheck for src, pl and contrib.
Thoughts?
cheers
andrew
| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: make everything target |
| Date: | 2010-01-27 18:28:06 |
| Message-ID: | 1264616886.4720.0.camel@vanquo.pezone.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On ons, 2010-01-27 at 10:41 -0500, Andrew Dunstan wrote:
> I'd like to have an "everything" target that would build "all + html +
> contrib".
+10
> And maybe an "installcheck-everything" target that would run
> installcheck for src, pl and contrib.
+100
| From: | David Fetter <david(at)fetter(dot)org> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: make everything target |
| Date: | 2010-01-27 22:10:01 |
| Message-ID: | 20100127221001.GZ31281@fetter.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Wed, Jan 27, 2010 at 10:41:16AM -0500, Andrew Dunstan wrote:
>
> I'd like to have an "everything" target that would build "all + html
> + contrib".
>
> And maybe an "installcheck-everything" target that would run
> installcheck for src, pl and contrib.
>
> Thoughts?
+1 on both :)
Cheers,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics
Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: make everything target |
| Date: | 2010-01-27 22:38:37 |
| Message-ID: | 15550.1264631917@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> On ons, 2010-01-27 at 10:41 -0500, Andrew Dunstan wrote:
>> I'd like to have an "everything" target that would build "all + html +
>> contrib".
> +10
>> And maybe an "installcheck-everything" target that would run
>> installcheck for src, pl and contrib.
> +100
These proposals sound reasonable to me too, but is "everything" an
appropriate target name, or is there some other/better convention?
I assume we don't want to mess with the default behavior (I don't
want to, anyway).
regards, tom lane
| From: | "David E(dot) Wheeler" <david(at)kineticode(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: make everything target |
| Date: | 2010-01-27 22:51:29 |
| Message-ID: | 15BE6E60-44D3-4E39-A07E-3A1A6312AB7D@kineticode.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Jan 27, 2010, at 2:38 PM, Tom Lane wrote:
> These proposals sound reasonable to me too, but is "everything" an
> appropriate target name, or is there some other/better convention?
Oooh, more bike-shedding.
make theworld
make toutlemonde
make myday
make lovenotwar
Best,
David
| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: make everything target |
| Date: | 2010-01-27 23:02:23 |
| Message-ID: | 4B60C5FF.4010609@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
>
>> On ons, 2010-01-27 at 10:41 -0500, Andrew Dunstan wrote:
>>
>>> I'd like to have an "everything" target that would build "all + html +
>>> contrib".
>>>
>
>
>> +10
>>
>
>
>>> And maybe an "installcheck-everything" target that would run
>>> installcheck for src, pl and contrib.
>>>
>
>
>> +100
>>
>
> These proposals sound reasonable to me too, but is "everything" an
> appropriate target name, or is there some other/better convention?
>
I'm not invested in the name. Suggestions welcome.
> I assume we don't want to mess with the default behavior (I don't
> want to, anyway).
>
>
Me either, although it's a bit of a pity history has stuck us with the
default behaviour.
cheers
andrew
| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | "David E(dot) Wheeler" <david(at)kineticode(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: make everything target |
| Date: | 2010-01-28 01:03:55 |
| Message-ID: | 20100128010355.GH3559@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
David E. Wheeler wrote:
> On Jan 27, 2010, at 2:38 PM, Tom Lane wrote:
>
> > These proposals sound reasonable to me too, but is "everything" an
> > appropriate target name, or is there some other/better convention?
>
> Oooh, more bike-shedding.
>
> make theworld
> make toutlemonde
"make world" sounds reasonable and I've remember seeing it elsewhere.
--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Cc: | "David E(dot) Wheeler" <david(at)kineticode(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: make everything target |
| Date: | 2010-01-28 02:44:55 |
| Message-ID: | 4B60FA27.7040806@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Alvaro Herrera wrote:
> "make world" sounds reasonable and I've remember seeing it elsewhere.
>
Here's a simple patch. Comments?
cheers
andrew
| Attachment | Content-Type | Size |
|---|---|---|
| pgmakefile.patch | text/x-patch | 1.4 KB |
| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | "David E(dot) Wheeler" <david(at)kineticode(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: make everything target |
| Date: | 2010-01-28 13:28:17 |
| Message-ID: | 20100128132817.GA3536@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Andrew Dunstan wrote:
>
>
> Alvaro Herrera wrote:
> >"make world" sounds reasonable and I've remember seeing it elsewhere.
>
> Here's a simple patch. Comments?
Should the new targets be added to Makefile too?
--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Cc: | "David E(dot) Wheeler" <david(at)kineticode(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: make everything target |
| Date: | 2010-01-28 13:35:42 |
| Message-ID: | 4B6192AE.3060002@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Alvaro Herrera wrote:
> Andrew Dunstan wrote:
>
>> Alvaro Herrera wrote:
>>
>>> "make world" sounds reasonable and I've remember seeing it elsewhere.
>>>
>> Here's a simple patch. Comments?
>>
>
> Should the new targets be added to Makefile too?
>
>
Sure, good idea.
cheers
andrew
| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Cc: | "David E(dot) Wheeler" <david(at)kineticode(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: make everything target |
| Date: | 2010-01-28 21:21:44 |
| Message-ID: | 4B61FFE8.2000100@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
I wrote:
>
>
> Alvaro Herrera wrote:
>> Andrew Dunstan wrote:
>>
>>> Alvaro Herrera wrote:
>>>
>>>> "make world" sounds reasonable and I've remember seeing it elsewhere.
>>>>
>>> Here's a simple patch. Comments?
>>>
>>
>> Should the new targets be added to Makefile too?
>>
>>
>
> Sure, good idea.
>
>
One more thing: do we want the new targets "world" and "install-world"
documented, or just left for developers?
cheers
andrew
| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, "David E(dot) Wheeler" <david(at)kineticode(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: make everything target |
| Date: | 2010-01-28 23:09:05 |
| Message-ID: | 1264720145.14250.1.camel@vanquo.pezone.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On tor, 2010-01-28 at 16:21 -0500, Andrew Dunstan wrote:
> One more thing: do we want the new targets "world" and
> "install-world"
> documented, or just left for developers?
Document them. How else would new developers learn about them?