Re: per-user pg_service.conf

I was surprised/annoyed to find out that there is no way to have
per-user pg_service.conf, something like ~/.pg_service.conf (well,
except by export PGSYSCONFDIR). That would be easy to add. Comments?

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> I was surprised/annoyed to find out that there is no way to have
> per-user pg_service.conf, something like ~/.pg_service.conf (well,
> except by export PGSYSCONFDIR). That would be easy to add. Comments?

+1.

I'll use it the day it exists.
--
dim

On Wed, Jan 13, 2010 at 11:49:59PM +0200, Peter Eisentraut wrote:
> I was surprised/annoyed to find out that there is no way to have
> per-user pg_service.conf, something like ~/.pg_service.conf (well,
> except by export PGSYSCONFDIR). That would be easy to add. Comments?

+1 from me. I was similarly surprised to learn the same thing recently, but
admit I didn't take the time see how easily it could be changed.

--
Joshua Tolley / eggyknap
End Point Corporation
http://www.endpoint.com

On ons, 2010-01-13 at 23:49 +0200, Peter Eisentraut wrote:
> I was surprised/annoyed to find out that there is no way to have
> per-user pg_service.conf, something like ~/.pg_service.conf (well,
> except by export PGSYSCONFDIR). That would be easy to add. Comments?

Here's a patch. Perhaps those who had said they would like that can
validate the behavior.

> > I was surprised/annoyed to find out that there is no way to have
> > per-user pg_service.conf, something like ~/.pg_service.conf (well,
> > except by export PGSYSCONFDIR). That would be easy to add.
> > Comments?
>
> Here's a patch. Perhaps those who had said they would like that can
> validate the behavior.

Hi,

I just tried the ~/.pg_service.conf patch and it does everything I'd
expect from it. It even improves the documentation to include a
services file example for which I had been looking several times
earlier.

There's not much I have to add, maybe the documentation could add a
pointer to what keywords are recognized:

| The file uses an "INI file" format where the section name is the
| service name and the parameters are connection parameters.

... (see Section 30.1 for a list).

Independently for what this patch changes, error reporting could be
more detailed, currently "syntax error in service file \"%s\", line
%d" is reported for "no = in line" and "keyword X is unknown". The
latter case deserves a different message, maybe like "keyword \"%s\"
is invalid in service file \"%s\", line %d".

Even without the proposed changed, I'd very much appreciate the patch
getting included.

Christoph
--
cb(at)df7cb(dot)de | http://www.df7cb.de/

committed

On fre, 2010-01-15 at 13:37 +0100, Christoph Berg wrote:
> There's not much I have to add, maybe the documentation could add a
> pointer to what keywords are recognized:
>
> | The file uses an "INI file" format where the section name is the
> | service name and the parameters are connection parameters.
>
> ... (see Section 30.1 for a list).

I added that.

>
> Independently for what this patch changes, error reporting could be
> more detailed, currently "syntax error in service file \"%s\", line
> %d" is reported for "no = in line" and "keyword X is unknown". The
> latter case deserves a different message, maybe like "keyword \"%s\"
> is invalid in service file \"%s\", line %d".

That was a bit outside of the mandate of the patch, but if someone wants
to send in something for that, I'm sure it would be considered.