| Lists: | pgsql-hackers |
|---|
| From: | Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> |
|---|---|
| To: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Subject: | [PATCH] Add solaris path for docbook COLLATEINDEX |
| Date: | 2009-11-25 20:36:11 |
| Message-ID: | 1259181371.1190.8.camel@localhost |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
collateindex.pl is stored in /usr/share/sgml/docbook/. Attached fix
modify docbook.m4 to find correct path.
It would be nice also backported the fix back at least to 8.2.
Thanks Zdenek
| Attachment | Content-Type | Size |
|---|---|---|
| docbook.patch | text/x-patch | 491 bytes |
| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Subject: | Re: [PATCH] Add solaris path for docbook COLLATEINDEX |
| Date: | 2009-11-30 17:32:22 |
| Message-ID: | 200911301732.nAUHWMB27650@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Zdenek Kotala wrote:
> collateindex.pl is stored in /usr/share/sgml/docbook/. Attached fix
> modify docbook.m4 to find correct path.
>
> It would be nice also backported the fix back at least to 8.2.
I am not happy looking in a directory _above_ a specified directory by
default:
[$DOCBOOKSTYLE/bin $DOCBOOKSTYLE/.. $PATH])
That seems possibly unsafe. I suggest you just add it to the PATH for
Solaris builds.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
| From: | Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Subject: | Re: [PATCH] Add solaris path for docbook COLLATEINDEX |
| Date: | 2009-11-30 18:53:18 |
| Message-ID: | 1259607198.1115.109.camel@localhost |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Bruce Momjian píše v po 30. 11. 2009 v 12:32 -0500:
> Zdenek Kotala wrote:
> > collateindex.pl is stored in /usr/share/sgml/docbook/. Attached fix
> > modify docbook.m4 to find correct path.
> >
> > It would be nice also backported the fix back at least to 8.2.
>
> I am not happy looking in a directory _above_ a specified directory by
> default:
>
> [$DOCBOOKSTYLE/bin $DOCBOOKSTYLE/.. $PATH])
>
> That seems possibly unsafe. I suggest you just add it to the PATH for
> Solaris builds.
I'm not sure if it is unsafer that searching in $PATH. Anyway I don't
think that your proposed solution is good way. I'm able to do it but how
many other people can? Who know where collateindex.pl stays on Solaris?
configure is here to make live easier for people. If we know how to do
it automatically we should do it.
If you think that $DOCBOOKSTYLE/.. is not good than I propose to
use /usr/share/sgml/docbook/ directly.
Zdenek
| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> |
| Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Add solaris path for docbook COLLATEINDEX |
| Date: | 2009-11-30 19:27:37 |
| Message-ID: | 1259609257.24894.2.camel@vanquo.pezone.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On mån, 2009-11-30 at 19:53 +0100, Zdenek Kotala wrote:
> Bruce Momjian píše v po 30. 11. 2009 v 12:32 -0500:
> > I am not happy looking in a directory _above_ a specified directory by
> > default:
> >
> > [$DOCBOOKSTYLE/bin $DOCBOOKSTYLE/.. $PATH])
> >
> > That seems possibly unsafe. I suggest you just add it to the PATH for
> > Solaris builds.
>
> I'm not sure if it is unsafer that searching in $PATH. Anyway I don't
> think that your proposed solution is good way. I'm able to do it but how
> many other people can? Who know where collateindex.pl stays on Solaris?
> configure is here to make live easier for people. If we know how to do
> it automatically we should do it.
Note that $DOCBOOKSTYLE/bin corresponds to the location of the file in
an unpacked source archive and $PATH is of course where programs
normally go. The $DOCBOOKSTYLE/.. location makes no sense at all,
because that basically says that the installer intentionally moved the
file, but to a completely nonstandard location.
> If you think that $DOCBOOKSTYLE/.. is not good than I propose to
> use /usr/share/sgml/docbook/ directly.
That would be the less ugly solution.
| From: | Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Add solaris path for docbook COLLATEINDEX |
| Date: | 2009-11-30 19:57:22 |
| Message-ID: | 1259611042.1115.130.camel@localhost |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Peter Eisentraut píše v po 30. 11. 2009 v 21:27 +0200:
> On mån, 2009-11-30 at 19:53 +0100, Zdenek Kotala wrote:
> > Bruce Momjian píše v po 30. 11. 2009 v 12:32 -0500:
> > > I am not happy looking in a directory _above_ a specified directory by
> > > default:
> > >
> > > [$DOCBOOKSTYLE/bin $DOCBOOKSTYLE/.. $PATH])
> > >
> > > That seems possibly unsafe. I suggest you just add it to the PATH for
> > > Solaris builds.
> >
> > I'm not sure if it is unsafer that searching in $PATH. Anyway I don't
> > think that your proposed solution is good way. I'm able to do it but how
> > many other people can? Who know where collateindex.pl stays on Solaris?
> > configure is here to make live easier for people. If we know how to do
> > it automatically we should do it.
>
> Note that $DOCBOOKSTYLE/bin corresponds to the location of the file in
> an unpacked source archive and $PATH is of course where programs
> normally go. The $DOCBOOKSTYLE/.. location makes no sense at all,
> because that basically says that the installer intentionally moved the
> file, but to a completely nonstandard location.
I'm not sgml//docbook guru. Do you think that Solaris location of
collateindex.pl is wrong? Does exist any recommendation for this? I
could log a bug, but I need some link with recommendation.
> > If you think that $DOCBOOKSTYLE/.. is not good than I propose to
> > use /usr/share/sgml/docbook/ directly.
>
> That would be the less ugly solution.
Patch attached.
thanks Zdenek
| Attachment | Content-Type | Size |
|---|---|---|
| docbook_02.patch | text/x-patch | 498 bytes |
| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> |
| Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Add solaris path for docbook COLLATEINDEX |
| Date: | 2009-12-01 06:41:59 |
| Message-ID: | 1259649719.31730.1.camel@fsopti579.F-Secure.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On mån, 2009-11-30 at 20:57 +0100, Zdenek Kotala wrote:
> I'm not sgml//docbook guru. Do you think that Solaris location of
> collateindex.pl is wrong? Does exist any recommendation for this? I
> could log a bug, but I need some link with recommendation.
It's a normal program, so you install it where you would normally
install programs. Like /usr/bin/ or something similar.