Re: Synchronous replication: reading recovery.conf

Lists: pgsql-hackers
From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Synchronous replication: reading recovery.conf
Date: 2008-12-08 10:01:37
Message-ID: 493CF081.4020001@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

I haven't testsed, but it looks to me that the recovery.conf reading
patch doesn't work in EXEC_BACKEND mode (= Windows). You'll need to add
recoveryRestoreCommand to save/read_backend_parameters in postmaster.c.

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com


From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Synchronous replication: reading recovery.conf
Date: 2008-12-08 14:39:02
Message-ID: 1228747142.20796.661.camel@hp_dx2400_1
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


On Mon, 2008-12-08 at 12:01 +0200, Heikki Linnakangas wrote:

> I haven't testsed, but it looks to me that the recovery.conf reading
> patch doesn't work in EXEC_BACKEND mode (= Windows). You'll need to add
> recoveryRestoreCommand to save/read_backend_parameters in postmaster.c.

That comment has also already been made on the existing review thread.

We're discussing some architectural aspects, so it would be a good if
you were there also. It's important we all agree on those things.

--
Simon Riggs www.2ndQuadrant.com
PostgreSQL Training, Services and Support