Re: BUG #5447: VPATH install postgres.bki

The following bug has been logged online:

Bug reference: 5447
Logged by: Graham
Email address: lists(at)information-cascade(dot)co(dot)uk
PostgreSQL version: 9.0beta1
Operating system: linux
Description: VPATH install postgres.bki
Details:

Build with VPATH works well upto installing
postgresql-9.0beta1/src/backend/catalog/postgres.bki
which is in the source tree not the object tree

/bin/sh /tools/2000_src/pgsql/postgresql-9.0beta1/config/install-sh -c -m
644 postgres.bki '/tools/2000/pgsql/share/postgres.bki'
/tools/2000_src/pgsql/postgresql-9.0beta1/config/install-sh: postgres.bki
does not exist.
make[3]: *** [install-data] Error 1
make[3]: Leaving directory
`/media/hda9/tools/2000_obj/pgsql/postgresql-9.0beta1/src/backend/catalog'
make[2]: *** [install] Error 2

On 04/05/10 04:49, Graham wrote:
>
> The following bug has been logged online:
>
> Bug reference: 5447
> Logged by: Graham
> Email address: lists(at)information-cascade(dot)co(dot)uk
> PostgreSQL version: 9.0beta1
> Operating system: linux
> Description: VPATH install postgres.bki
> Details:
>
> Build with VPATH works well upto installing
> postgresql-9.0beta1/src/backend/catalog/postgres.bki
> which is in the source tree not the object tree

I'm going to ask a stupid question:

"VPATH" ? What do you mean?

Also: You've omitted some key details, such as the command line(s) you
ran leading up to this error, the exact OS and distro version, your
version of gcc and make, etc.

--
Craig Ringer

Please reply to the list, not just to me. The "Reply all" button in your
mail client should take care of that.

Reply follows.

On 4/05/2010 9:16 PM, Graham Swallow wrote:
> I fixed it for me at home by copying three files,
> from the source tree to the object tree,
> where makefile expected them to be
> (it had forgot $PWD is in _obj/... not in _src/...).
>
> postgres.bki
> postgres.description
> postgres.shdescription

OK, you're referring to out-of-tree builds. Sorry, I mostly work with
CMake not autotools, so "VPATH" didn't leap out at me.

Sounds like it's just a mattter of adding appropriate variable
substitutions for the install lines of those files. I'll look at it in
the morning (it's late here) if nobody beats me to it - this is probably
something my meagre skills are actually up to ;-)

--
Craig Ringer

(1) Thanks, I hope that PG9 is as good as it can be
(2) I had hoped that gmail would reply-all, doing "the right thing"
(3) Mailing list? This is a mailing list?

You mean when I grumble into this web-form,
it gets broadcast over the public address tannoy?
WOW !

Graham

On 4 May 2010 14:32, Craig Ringer <craig(at)postnewspapers(dot)com(dot)au> wrote:
> Please reply to the list, not just to me. The "Reply all" button in your
> mail client should take care of that.
>
> Reply follows.
>
> On 4/05/2010 9:16 PM, Graham Swallow wrote:
>>
>> I fixed it for me at home by copying three files,
>> from the source tree to the object tree,
>> where makefile expected them to be
>> (it had forgot $PWD is  in _obj/... not in _src/...).
>>
>>  postgres.bki
>>  postgres.description
>>  postgres.shdescription
>
> OK, you're referring to out-of-tree builds. Sorry, I mostly work with CMake
> not autotools, so "VPATH" didn't leap out at me.
>
> Sounds like it's just a mattter of adding appropriate variable substitutions
> for the install lines of those files. I'll look at it in the morning (it's
> late here) if nobody beats me to it - this is probably something my meagre
> skills are actually up to ;-)
>
> --
> Craig Ringer
>

Graham wrote:

> Build with VPATH works well upto installing
> postgresql-9.0beta1/src/backend/catalog/postgres.bki
> which is in the source tree not the object tree

Strange. I always use VPATH builds and I've never seen this problem. I
only use CVS checkouts though. Maybe something is broken in the
tarball. I'll have a look this afternoon is no one beats me to it.

PS: yes, it's a mailing list -- see
http://archives.postgresql.org/pgsql-bugs/2010-05

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> Graham wrote:
>> Build with VPATH works well upto installing
>> postgresql-9.0beta1/src/backend/catalog/postgres.bki
>> which is in the source tree not the object tree

> Strange. I always use VPATH builds and I've never seen this problem. I
> only use CVS checkouts though. Maybe something is broken in the
> tarball. I'll have a look this afternoon is no one beats me to it.

I don't think anyone has tried a VPATH build starting from a
distribution tarball. The OP is correct that things are going to fall
over in that case. My thought about fixing it was that postgres.bki
and related files ought to be forced to be built/used in $(srcdir),
but I didn't get further than that. Peter, what do you think?

regards, tom lane

On tis, 2010-05-04 at 10:49 -0400, Tom Lane wrote:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> > Graham wrote:
> >> Build with VPATH works well upto installing
> >> postgresql-9.0beta1/src/backend/catalog/postgres.bki
> >> which is in the source tree not the object tree
>
> > Strange. I always use VPATH builds and I've never seen this problem. I
> > only use CVS checkouts though. Maybe something is broken in the
> > tarball. I'll have a look this afternoon is no one beats me to it.
>
> I don't think anyone has tried a VPATH build starting from a
> distribution tarball. The OP is correct that things are going to fall
> over in that case. My thought about fixing it was that postgres.bki
> and related files ought to be forced to be built/used in $(srcdir),
> but I didn't get further than that. Peter, what do you think?

We have a prebaked solution for this in the docs build. The attached
patch appears to fix it.

On tis, 2010-05-04 at 22:46 +0300, Peter Eisentraut wrote:
> On tis, 2010-05-04 at 10:49 -0400, Tom Lane wrote:
> > Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> > > Graham wrote:
> > >> Build with VPATH works well upto installing
> > >> postgresql-9.0beta1/src/backend/catalog/postgres.bki
> > >> which is in the source tree not the object tree
> >
> > > Strange. I always use VPATH builds and I've never seen this problem. I
> > > only use CVS checkouts though. Maybe something is broken in the
> > > tarball. I'll have a look this afternoon is no one beats me to it.
> >
> > I don't think anyone has tried a VPATH build starting from a
> > distribution tarball. The OP is correct that things are going to fall
> > over in that case. My thought about fixing it was that postgres.bki
> > and related files ought to be forced to be built/used in $(srcdir),
> > but I didn't get further than that. Peter, what do you think?
>
> We have a prebaked solution for this in the docs build. The attached
> patch appears to fix it.

Committed