Re: Patch to inline stable SQL set returning UDFs

Lists: pgsql-patches
From: "Richard Rowell" <richard(dot)rowell(at)gmail(dot)com>
To: pgsql-patches(at)postgresql(dot)org
Subject: Patch to inline stable SQL set returning UDFs
Date: 2007-10-01 16:17:14
Message-ID: b61e61d30710010917s6469aeebwf5913f6a597d3fe4@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-patches

I discussed this hack with Neil and Josh in Ottawa back in May. I
took a stab at it a few weeks ago and below are the results. It is
mostly modeled after the existing inline_function. The approach taken
is to recursively cleanup the RTable where stable SQL functions are
found in it.

I've been testing this in our dev environment for a few weeks now.
I'm sure it still has issues but I think it is about as clean as I can
get it without help from a wider audience. This is my first backend
patch so please be gentle.

I want to thank Neil for answering many of my supremely ignorant
questions on IRC.

--
"An eye for eye only ends up making the whole world blind." -- Mohandas Gandhi

Attachment Content-Type Size
inline_stable_sql_srfs-v3.patch text/x-patch 13.5 KB

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Richard Rowell" <richard(dot)rowell(at)gmail(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Patch to inline stable SQL set returning UDFs
Date: 2008-03-18 22:05:29
Message-ID: 12246.1205877929@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-patches

"Richard Rowell" <richard(dot)rowell(at)gmail(dot)com> writes:
> I discussed this hack with Neil and Josh in Ottawa back in May. I
> took a stab at it a few weeks ago and below are the results. It is
> mostly modeled after the existing inline_function. The approach taken
> is to recursively cleanup the RTable where stable SQL functions are
> found in it.

Applied with revisions --- the recursion issue wasn't being managed
properly, and there were some other problems ...

regards, tom lane