| Lists: | pgsql-hackers |
|---|
| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | SlruPhysicalReadPage |
| Date: | 2008-10-15 18:37:55 |
| Message-ID: | 1224095875.3808.201.camel@ebony.2ndQuadrant |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
SlruPhysicalReadPage() succeeds InRecovery if the file does not exist.
BUT, if the file exists but is wrong size then it will still fail even
InRecovery.
This seems inconsistent. Why is the first page OK to be created, but any
other pages after that cause failure? ISTM the first page is nothing
special.
I think this can cause recovery to fail *now*. What say you?
--
Simon Riggs www.2ndQuadrant.com
PostgreSQL Training, Services and Support
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: SlruPhysicalReadPage |
| Date: | 2008-10-15 19:13:58 |
| Message-ID: | 25772.1224098038@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Simon Riggs <simon(at)2ndQuadrant(dot)com> writes:
> This seems inconsistent. Why is the first page OK to be created, but any
> other pages after that cause failure? ISTM the first page is nothing
> special.
It's special on the writing side, I'm not sure why the reading side
wouldn't treat it specially too.
regards, tom lane
| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: SlruPhysicalReadPage |
| Date: | 2008-10-15 23:26:01 |
| Message-ID: | 1224113161.3808.253.camel@ebony.2ndQuadrant |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Wed, 2008-10-15 at 15:13 -0400, Tom Lane wrote:
> Simon Riggs <simon(at)2ndQuadrant(dot)com> writes:
> > This seems inconsistent. Why is the first page OK to be created, but any
> > other pages after that cause failure? ISTM the first page is nothing
> > special.
>
> It's special on the writing side, I'm not sure why the reading side
> wouldn't treat it specially too.
I've added code for seek and read also, not just open.
--
Simon Riggs www.2ndQuadrant.com
PostgreSQL Training, Services and Support