| Lists: | pgsql-hackers |
|---|
| From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
|---|---|
| To: | PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org> |
| Subject: | New compile warnings in CVS |
| Date: | 2004-10-26 17:37:49 |
| Message-ID: | 200410261737.i9QHbng21227@candle.pha.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
I just updated my CVS copy and am seeing four new warnings from
pgstat.c:
pgstat.c:2352: warning: variable `dbentry' might be clobbered by
`longjmp' or `vfork'
pgstat.c:2360: warning: variable `havebackends' might be clobbered by
`longjmp' or `vfork'
pgstat.c:2362: warning: variable `use_mcxt' might be clobbered by
`longjmp' or `vfork'
pgstat.c:2363: warning: variable `mcxt_flags' might be clobbered by
`longjmp' or `vfork'
Any ideas on this?
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
| From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: New compile warnings in CVS |
| Date: | 2004-10-26 17:42:42 |
| Message-ID: | 200410261742.i9QHggi22325@candle.pha.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Bruce Momjian wrote:
> I just updated my CVS copy and am seeing four new warnings from
> pgstat.c:
>
> pgstat.c:2352: warning: variable `dbentry' might be clobbered by
> `longjmp' or `vfork'
> pgstat.c:2360: warning: variable `havebackends' might be clobbered by
> `longjmp' or `vfork'
> pgstat.c:2362: warning: variable `use_mcxt' might be clobbered by
> `longjmp' or `vfork'
> pgstat.c:2363: warning: variable `mcxt_flags' might be clobbered by
> `longjmp' or `vfork'
>
> Any ideas on this?
Oh this is BSD/OS 4.3 using gcc:
gcc version 2.95.3 20010315 (release)
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Neil Conway <neilc(at)samurai(dot)com> |
| Subject: | Re: New compile warnings in CVS |
| Date: | 2004-10-26 17:57:05 |
| Message-ID: | 12082.1098813425@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> I just updated my CVS copy and am seeing four new warnings from
> pgstat.c:
> pgstat.c:2352: warning: variable `dbentry' might be clobbered by
> `longjmp' or `vfork'
> pgstat.c:2360: warning: variable `havebackends' might be clobbered by
> `longjmp' or `vfork'
> pgstat.c:2362: warning: variable `use_mcxt' might be clobbered by
> `longjmp' or `vfork'
> pgstat.c:2363: warning: variable `mcxt_flags' might be clobbered by
> `longjmp' or `vfork'
No doubt this is from the PG_TRY that Neil added a couple days ago.
I think he is going to take it out again in favor of using AllocateFile,
so ignore the warnings for now (they're obviously bogus anyway).
regards, tom lane
| From: | Neil Conway <neilc(at)samurai(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: New compile warnings in CVS |
| Date: | 2004-10-27 00:52:43 |
| Message-ID: | 1098838363.1964.1.camel@localhost.localdomain |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Wed, 2004-10-27 at 03:57, Tom Lane wrote:
> No doubt this is from the PG_TRY that Neil added a couple days ago.
> I think he is going to take it out again in favor of using AllocateFile,
> so ignore the warnings for now (they're obviously bogus anyway).
Sorry, I didn't see those compile warnings locally (using GCC 3.3).
I'll send the patch for AllocateFile() to -patches shortly.
-Neil