Re: gendef fixes

Lists: pgsql-patches
From: Magnus Hagander <magnus(at)hagander(dot)net>
To: pgsql-patches(at)postgresql(dot)org
Subject: gendef fixes
Date: 2007-01-09 11:29:55
Message-ID: 20070109112955.GA18687@svr2.hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-patches

Attached patch fixes two problems:

1) gendef works from inside visual studio - use a tempfile instead of
redirection, because for some reason you can't redirect dumpbin from
inside (patch from Joachim Wieland)
2) gendef must process only *.obj, or you get weird errors in some build
scenarios when it tries to process a logfile

//Magnus

Attachment Content-Type Size
gendef.patch text/plain 1.0 KB

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: gendef fixes
Date: 2007-01-09 22:20:29
Message-ID: 200701092220.l09MKT121825@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-patches


Your patch has been added to the PostgreSQL unapplied patches list at:

http://momjian.postgresql.org/cgi-bin/pgpatches

It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.

---------------------------------------------------------------------------
Magnus Hagander wrote:
> Attached patch fixes two problems:
>
> 1) gendef works from inside visual studio - use a tempfile instead of
> redirection, because for some reason you can't redirect dumpbin from
> inside (patch from Joachim Wieland)
> 2) gendef must process only *.obj, or you get weird errors in some build
> scenarios when it tries to process a logfile
>
>
> //Magnus
>

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: don't forget to increase your free space map settings

--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +


From: Neil Conway <neilc(at)samurai(dot)com>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: gendef fixes
Date: 2007-01-10 04:02:26
Message-ID: 1168401746.4412.2.camel@neilc-laptop
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-patches

On Tue, 2007-01-09 at 12:29 +0100, Magnus Hagander wrote:
> Attached patch fixes two problems:

Applied, thanks.

-Neil