| Lists: | pgsql-hackerspgsql-patches |
|---|
| From: | Sven Suursoho <pg(at)spam(dot)pri(dot)ee> |
|---|---|
| To: | pgsql-patches(at)postgresql(dot)org |
| Subject: | plpython improvements |
| Date: | 2006-08-11 17:10:30 |
| Message-ID: | 1155316230.44dcba0692a82@webmail.elion.ee |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers pgsql-patches |
Hello,
As previous patch seems to be forgotten I send it again, updated against
current
HEAD.
Summary of changes:
* return SETOF as Python's sequence types (tuple, list) or using iterator
or
generator
* return composite types as sequence (tuple, list), mapping (dict) or class
(actually any object providing method __getattr__)
* named procedure arguments
Regression tests are also updated to include testing of new features and
existing tests to use named procedure parameters.
--
Sven Suursoho
| Attachment | Content-Type | Size |
|---|---|---|
| plpython.patch | text/x-patch | 48.6 KB |
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Cc: | Sven Suursoho <pg(at)spam(dot)pri(dot)ee> |
| Subject: | Re: [PATCHES] plpython improvements |
| Date: | 2006-08-18 20:27:23 |
| Message-ID: | 24610.1155932843@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers pgsql-patches |
Anyone in a position to review the pending plpython patch?
http://archives.postgresql.org/pgsql-patches/2006-08/msg00151.php
After that little fiasco with plperl I'm disinclined to apply anything
without review by somebody who's pretty familiar with the PL in
question ... and Python's not my language.
regards, tom lane
| From: | Michael Fuhr <mike(at)fuhr(dot)org> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Sven Suursoho <pg(at)spam(dot)pri(dot)ee> |
| Subject: | Re: [PATCHES] plpython improvements |
| Date: | 2006-08-18 21:17:14 |
| Message-ID: | 20060818211714.GA85419@winnie.fuhr.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers pgsql-patches |
On Fri, Aug 18, 2006 at 04:27:23PM -0400, Tom Lane wrote:
> Anyone in a position to review the pending plpython patch?
> http://archives.postgresql.org/pgsql-patches/2006-08/msg00151.php
In several places the code does this:
so = PyObject_Str(value);
valuestr = PyString_AsString(so);
We've previously learned that calling PyString_AsString() without
checking the return value of PyObject_Str() can result in a
segmentation fault.
http://archives.postgresql.org/pgsql-committers/2005-07/msg00233.php
I haven't examined the current patch closely enough to know whether
PyObject_Str() can possibly return NULL, but several occurrences
of the above code snippet caught my eye because we had dealt with
it before.
--
Michael Fuhr
| From: | andrew(at)dunslane(dot)net |
|---|---|
| To: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, "Sven Suursoho" <pg(at)spam(dot)pri(dot)ee> |
| Subject: | Re: [PATCHES] plpython improvements |
| Date: | 2006-08-18 22:27:23 |
| Message-ID: | 1032.24.211.165.134.1155940043.squirrel@www.dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers pgsql-patches |
Tom Lane wrote:
> Anyone in a position to review the pending plpython patch?
> http://archives.postgresql.org/pgsql-patches/2006-08/msg00151.php
>
> After that little fiasco with plperl I'm disinclined to apply anything
> without review by somebody who's pretty familiar with the PL in
> question ... and Python's not my language.
>
>
does it have docs?
cheers
andrew