| Lists: | pgsql-patches |
|---|
| From: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
|---|---|
| To: | pgsql-patches(at)postgresql(dot)org |
| Subject: | archiver.pid |
| Date: | 2006-05-22 16:29:14 |
| Message-ID: | 1148315354.2646.782.camel@localhost.localdomain |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
Lock file to prevent starting with multiple archivers present.
Possibly some debate over exact behaviour, but publish early...
--
Simon Riggs
EnterpriseDB http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| arch.pid.patch | text/x-patch | 22.2 KB |
| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
| Cc: | pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: archiver.pid |
| Date: | 2006-05-22 22:07:52 |
| Message-ID: | 20060522220752.GD20221@surnet.cl |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
Simon Riggs wrote:
> Lock file to prevent starting with multiple archivers present.
Isn't it cleaner to remove the PID file in postmaster.c:reaper()? That
way you are really sure that the PID file is removed when the process is
gone, even if it crashes.
OTOH I don't think it's very clean to change the semantics of the
ArchPid variable in postmaster. We use those to keep track of the
running process, so if there's no archiver, it should be 0 (which is
true for all said variables).
--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
| From: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
|---|---|
| To: | pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: archiver.pid |
| Date: | 2006-05-23 15:23:55 |
| Message-ID: | 1148397835.2646.845.camel@localhost.localdomain |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
On Mon, 2006-05-22 at 17:29 +0100, Simon Riggs wrote:
> Lock file to prevent starting with multiple archivers present.
>
> Possibly some debate over exact behaviour, but publish early...
Original patch withdrawn.
New patch included.
--
Simon Riggs
EnterpriseDB http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| archloop.patch | text/x-patch | 831 bytes |
| From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
|---|---|
| To: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
| Cc: | pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: archiver.pid |
| Date: | 2006-05-30 13:30:13 |
| Message-ID: | 200605301330.k4UDUDM08402@candle.pha.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
Patch applied to CVS HEAD and 8.1.X. Thanks.
---------------------------------------------------------------------------
Simon Riggs wrote:
> On Mon, 2006-05-22 at 17:29 +0100, Simon Riggs wrote:
> > Lock file to prevent starting with multiple archivers present.
> >
> > Possibly some debate over exact behaviour, but publish early...
>
> Original patch withdrawn.
>
> New patch included.
>
> --
> Simon Riggs
> EnterpriseDB http://www.enterprisedb.com
[ Attachment, skipping... ]
>
> ---------------------------(end of broadcast)---------------------------
> TIP 4: Have you searched our list archives?
>
> http://archives.postgresql.org
--
Bruce Momjian http://candle.pha.pa.us
EnterpriseDB http://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +