Allow setObject(x,y,Types.BIT) if y is a Number & getObject() on bit columns

Problem:
- setObject(x,y,Types.BIT) throws an exception if y is a Number
- getObject() on a bit column will return null instead of True or False
Boolean objects

Fix:
- Added check in setObject() to check to that the Number has value==1.
If so, set to True. False otherwise. This seems to be consistent with
the rest of the code.
- Added BIT to JDBC datatype list

Cheers,

Kim

On Wed, 2003-06-18 at 13:09, Kim Ho wrote:
> Problem:
> - setObject(x,y,Types.BIT) throws an exception if y is a Number
> - getObject() on a bit column will return null instead of True or False
> Boolean objects
>
Added Problem:
- Doesn't set bit columns

> Fix:
> - Added check in setObject() to check to that the Number has value==1.
> If so, set to True. False otherwise. This seems to be consistent with
> the rest of the code.
> - Added BIT to JDBC datatype list
- Using way to set values in both boolean/bit type columns

It works now.

The following program works now:

Statement stmt = con.createStatement();
stmt.execute("Create Table bit_tab (b bit)");

PreparedStatement pstmt = con.prepareStatement("insert into bit_tab
values (?)");
pstmt.setBoolean(1,true);
pstmt.execute();

Sorry bout the delay.

Cheers,

Kim

Kim,

Are you going to be submitting a patch for this?

thanks,
--Barry

Kim Ho wrote:
> On Wed, 2003-06-18 at 13:09, Kim Ho wrote:
>
>>Problem:
>> - setObject(x,y,Types.BIT) throws an exception if y is a Number
>> - getObject() on a bit column will return null instead of True or False
>>Boolean objects
>>
>
> Added Problem:
> - Doesn't set bit columns
>
>
>>Fix:
>> - Added check in setObject() to check to that the Number has value==1.
>>If so, set to True. False otherwise. This seems to be consistent with
>>the rest of the code.
>> - Added BIT to JDBC datatype list
>
> - Using way to set values in both boolean/bit type columns
>
> It works now.
>
> The following program works now:
>
> Statement stmt = con.createStatement();
> stmt.execute("Create Table bit_tab (b bit)");
>
> PreparedStatement pstmt = con.prepareStatement("insert into bit_tab
> values (?)");
> pstmt.setBoolean(1,true);
> pstmt.execute();
>
> Sorry bout the delay.
>
> Cheers,
>
> Kim
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 7: don't forget to increase your free space map settings
>

Oops. Forgot to attach it last time.

On Mon, 2003-06-30 at 12:44, Barry Lind wrote:
> Kim,
>
> Are you going to be submitting a patch for this?
>
> thanks,
> --Barry
>
>
> Kim Ho wrote:
> > On Wed, 2003-06-18 at 13:09, Kim Ho wrote:
> >
> >>Problem:
> >> - setObject(x,y,Types.BIT) throws an exception if y is a Number
> >> - getObject() on a bit column will return null instead of True or False
> >>Boolean objects
> >>
> >
> > Added Problem:
> > - Doesn't set bit columns
> >
> >
> >>Fix:
> >> - Added check in setObject() to check to that the Number has value==1.
> >>If so, set to True. False otherwise. This seems to be consistent with
> >>the rest of the code.
> >> - Added BIT to JDBC datatype list
> >
> > - Using way to set values in both boolean/bit type columns
> >
> > It works now.
> >
> > The following program works now:
> >
> > Statement stmt = con.createStatement();
> > stmt.execute("Create Table bit_tab (b bit)");
> >
> > PreparedStatement pstmt = con.prepareStatement("insert into bit_tab
> > values (?)");
> > pstmt.setBoolean(1,true);
> > pstmt.execute();
> >
> > Sorry bout the delay.
> >
> > Cheers,
> >
> > Kim
> >
> >
> > ---------------------------(end of broadcast)---------------------------
> > TIP 7: don't forget to increase your free space map settings
> >
>
>

Patch applied,

thanks,
Dave
On Wed, 2003-06-18 at 13:09, Kim Ho wrote:
> Problem:
> - setObject(x,y,Types.BIT) throws an exception if y is a Number
> - getObject() on a bit column will return null instead of True or False
> Boolean objects
>
> Fix:
> - Added check in setObject() to check to that the Number has value==1.
> If so, set to True. False otherwise. This seems to be consistent with
> the rest of the code.
> - Added BIT to JDBC datatype list
>
>
> Cheers,
>
> Kim
>
> ______________________________________________________________________
>
> ---------------------------(end of broadcast)---------------------------
> TIP 1: subscribe and unsubscribe commands go to majordomo(at)postgresql(dot)org
--
Dave Cramer <Dave(at)micro-automation(dot)net>