Re: Patch needed fot dt.h

Lists: pgsql-patches
From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Patch needed fot dt.h
Date: 2007-05-21 07:43:56
Message-ID: 46514DBC.1090801@lelarge.info
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-patches

Hi all,

With latest modification on src/interfaces/ecpg/pgtypeslib/dt_common.c,
DTK_ISODOW is not defined. The patch attached needs to be applied on 8.1
and 8.2 branches to compile successfully.

Regards.

--
Guillaume.
<!-- http://abs.traduc.org/
http://lfs.traduc.org/
http://docs.postgresqlfr.org/ -->

Attachment Content-Type Size
dt_h.patch text/x-patch 4.0 KB

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Cc: Patches <pgsql-patches(at)postgresql(dot)org>, meskes(at)postgresql(dot)org (Michael Meskes)
Subject: Re: Patch needed fot dt.h
Date: 2007-05-21 14:17:30
Message-ID: 10457.1179757050@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-patches

Guillaume Lelarge <guillaume(at)lelarge(dot)info> writes:
> With latest modification on src/interfaces/ecpg/pgtypeslib/dt_common.c,
> DTK_ISODOW is not defined. The patch attached needs to be applied on 8.1
> and 8.2 branches to compile successfully.

I'm wondering why the back-branch patches added a dependency on
DTK_ISODOW in the first place. That looks more like a copy&paste
error than something intentional. Michael?

regards, tom lane


From: Michael Meskes <meskes(at)postgresql(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Guillaume Lelarge <guillaume(at)lelarge(dot)info>, Patches <pgsql-patches(at)postgresql(dot)org>, Michael Meskes <meskes(at)postgresql(dot)org>
Subject: Re: Patch needed fot dt.h
Date: 2007-05-21 14:58:29
Message-ID: 20070521145829.GA9126@feivel.credativ.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-patches

On Mon, May 21, 2007 at 10:17:30AM -0400, Tom Lane wrote:
> I'm wondering why the back-branch patches added a dependency on
> DTK_ISODOW in the first place. That looks more like a copy&paste
> error than something intentional. Michael?

It is, somehow it slipped through. Just removed it.

Michael
--
Michael Meskes
Email: Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
ICQ: 179140304, AIM/Yahoo: michaelmeskes, Jabber: meskes(at)jabber(dot)org
Go SF 49ers! Go Rhein Fire! Use Debian GNU/Linux! Use PostgreSQL!