| Lists: | pgsql-hackers |
|---|
| From: | "Jeroen T(dot) Vermeulen" <jtv(at)xs4all(dot)nl> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | psql source suggestions |
| Date: | 2003-02-13 03:23:07 |
| Message-ID: | 20030213032307.GC17237@bulletproof |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
I've been playing around with the source for psql, and as a result I
did some cleaning up in common.c. Would anyone be interested in seeing
patches for that? The main benefit is some eliminated code duplication,
plus the removal of some warts like 'continue' and 'break' where they
weren't needed.
Jeroen
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | "Jeroen T(dot) Vermeulen" <jtv(at)xs4all(dot)nl> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: psql source suggestions |
| Date: | 2003-02-13 04:38:11 |
| Message-ID: | 10392.1045111091@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
"Jeroen T. Vermeulen" <jtv(at)xs4all(dot)nl> writes:
> I've been playing around with the source for psql, and as a result I
> did some cleaning up in common.c. Would anyone be interested in seeing
> patches for that? The main benefit is some eliminated code duplication,
> plus the removal of some warts like 'continue' and 'break' where they
> weren't needed.
Sure, send it along to pgsql-patches. Code beautification is a
worthwhile goal that we spend far too little time on.
Of course, beauty is in the eye of the beholder, so there may not be
universal agreement that you made improvements ;-). But send 'em along
and then we can debate the point.
regards, tom lane
| From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
|---|---|
| To: | "Jeroen T(dot) Vermeulen" <jtv(at)xs4all(dot)nl> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: psql source suggestions |
| Date: | 2003-02-13 04:47:39 |
| Message-ID: | 200302130447.h1D4ldd29153@candle.pha.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Sure. Shoot them over.
---------------------------------------------------------------------------
Jeroen T. Vermeulen wrote:
> I've been playing around with the source for psql, and as a result I
> did some cleaning up in common.c. Would anyone be interested in seeing
> patches for that? The main benefit is some eliminated code duplication,
> plus the removal of some warts like 'continue' and 'break' where they
> weren't needed.
>
>
> Jeroen
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 6: Have you searched our list archives?
>
> http://archives.postgresql.org
>
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073