Re: CommitFest 2009-07 - End of Week 1

A brief update on our progress so far. We started with 71 patches of
which 12 have been committed, 9 returned with feedback, 2 rejected,
and 1 bumped to the next CommitFest. In other words, we've closed out
just over a third of the total number of patches in the first week,
which is great progress. Many of the other patches are in the process
of being reviewed - either a review has already been posted and the
patch author is in the process of reworking it, or the reviewer has
begun reviewing but has not yet completed it. In order to make it
easier to get this status information, I've added a quick summary line
to the top of the CommitFest status page.

https://commitfest.postgresql.org/action/commitfest_view/inprogress

There are a few patches that have some level of committer endorsement
from previous discussions, and it's not clear whether any round-robin
review is required. These are:

Fix memory leak in win32 security functions (Magnus)
do_tup_output_datum v2 (Tom)

These might be worth a quick look by the respective committers to see
whether these can just go in. If not, we'll assign round-robin
reviewers.

A couple of other patches that seem to be problem cases are:

- Security Enhanced PostgreSQL. I don't think that there is any way
that this is going to be committable for this CommitFest, but I'm
willing to review it one more time this CommitFest before moving on.
At a minimum, I hope the discussion has made it clear that getting
this patch where it needs to me is going to take a lot of work, and
the fact that KaiGai was until yesterday the only one willing to do
any of that work is a significant problem.

- Indexam API changes, Index-only quals. These seem likely really
important patches, but it appears that they're not really done, and
Heikki is apparently on vacation (I'm not sure until when). It may be
necessary to bump these to the next CommitFest.

Thanks to all who have been helping with the review process. Please
remember to add reviews to the commitfest app and update the status of
the patch as well.

Thanks,

...Robert

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> There are a few patches that have some level of committer endorsement
> from previous discussions, and it's not clear whether any round-robin
> review is required. These are:

> Fix memory leak in win32 security functions (Magnus)
> do_tup_output_datum v2 (Tom)

> These might be worth a quick look by the respective committers to see
> whether these can just go in. If not, we'll assign round-robin
> reviewers.

Roger, I'll look at do_tup_output_datum in the morning, but I think
it's noncontroversial.

Magnus just got back from sailing and presumably will catch up on
his commitments in due course ...

regards, tom lane

On Wed, Jul 22, 2009 at 05:35, Tom Lane<tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> There are a few patches that have some level of committer endorsement
>> from previous discussions, and it's not clear whether any round-robin
>> review is required.  These are:
>
>> Fix memory leak in win32 security functions (Magnus)
>> do_tup_output_datum v2 (Tom)
>
>> These might be worth a quick look by the respective committers to see
>> whether these can just go in.  If not, we'll assign round-robin
>> reviewers.
>
> Roger, I'll look at do_tup_output_datum in the morning, but I think
> it's noncontroversial.
>
> Magnus just got back from sailing and presumably will catch up on
> his commitments in due course ...

Yeah, I'm still backlogged but I'm getting there. That specific patch
is something I've already reviewed, so I just need to verify there has
been no drift (not likely) and get it in. I expect to get to
commitfest work within a day or two.

--
Magnus Hagander
Self: http://www.hagander.net/
Work: http://www.redpill-linpro.com/