| Lists: | pgsql-hackers |
|---|
| From: | Bernd Helmle <mailings(at)oopsware(dot)de> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | PGXS contrib builds broken? |
| Date: | 2013-02-25 10:50:46 |
| Message-ID: | 17053B33A5E13A04E0A36D50@apophis.credativ.lan |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Looks like the recent refactoring of code into common/ stopped
PGXS builds within the PostgreSQL source tree from working, i get
/Users/bernd/pgsql-dev/install/HEAD/include/server/postgres_fe.h:27:32:
fatal error: common/fe_memutils.h: No such file or directory
when trying to build pg_upgrade, pgbench, pg_xlogdump, ... with PGXS.
I don't see common/fe_memutils getting installed in include/, so i suppose
either some bug between chair and keyboard or some inconsistencies here.
--
Thanks
Bernd
| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | Bernd Helmle <mailings(at)oopsware(dot)de> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: PGXS contrib builds broken? |
| Date: | 2013-02-26 12:57:46 |
| Message-ID: | 20130226125746.GA30358@awork2.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On 2013-02-25 11:50:46 +0100, Bernd Helmle wrote:
> Looks like the recent refactoring of code into common/ stopped
> PGXS builds within the PostgreSQL source tree from working, i get
>
> /Users/bernd/pgsql-dev/install/HEAD/include/server/postgres_fe.h:27:32:
> fatal error: common/fe_memutils.h: No such file or directory
Oh, yes. It wasn't added to the install target during the src/common
addition. Patch attached.
> when trying to build pg_upgrade, pgbench, pg_xlogdump, ... with PGXS.
>
> I don't see common/fe_memutils getting installed in include/, so i suppose
> either some bug between chair and keyboard or some inconsistencies here.
pg_xlogdump won't be buildable without a full sourcetree around though,
it needs too much backend infrastructure to be built...
Thats why I voted somewhere else to remove PGXS support from it and
error out instead...
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | Bernd Helmle <mailings(at)oopsware(dot)de> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: PGXS contrib builds broken? |
| Date: | 2013-02-26 13:00:26 |
| Message-ID: | 20130226130026.GB30358@awork2.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On 2013-02-26 13:57:46 +0100, Andres Freund wrote:
> On 2013-02-25 11:50:46 +0100, Bernd Helmle wrote:
> > Looks like the recent refactoring of code into common/ stopped
> > PGXS builds within the PostgreSQL source tree from working, i get
> >
> > /Users/bernd/pgsql-dev/install/HEAD/include/server/postgres_fe.h:27:32:
> > fatal error: common/fe_memutils.h: No such file or directory
>
> Oh, yes. It wasn't added to the install target during the src/common
> addition. Patch attached.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| install-common-headers.patch | text/x-patch | 1.0 KB |
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Bernd Helmle <mailings(at)oopsware(dot)de>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: PGXS contrib builds broken? |
| Date: | 2013-02-26 20:28:27 |
| Message-ID: | 10029.1361910507@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> On 2013-02-26 13:57:46 +0100, Andres Freund wrote:
>> On 2013-02-25 11:50:46 +0100, Bernd Helmle wrote:
>>> Looks like the recent refactoring of code into common/ stopped
>>> PGXS builds within the PostgreSQL source tree from working, i get
>>> /Users/bernd/pgsql-dev/install/HEAD/include/server/postgres_fe.h:27:32:
>>> fatal error: common/fe_memutils.h: No such file or directory
>> Oh, yes. It wasn't added to the install target during the src/common
>> addition. Patch attached.
Pushed, thanks.
regards, tom lane