Thread safety

Lists: pgsql-hackers
From: Magnus Hagander <magnus(at)hagander(dot)net>
To: PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Thread safety
Date: 2008-11-27 06:59:39
Message-ID: 0D37E7B0-3B06-4E7F-9A40-EC4CDB6D6B3E@hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Can someone remind me why we have --enable-thread-safety? As opposed
to it being default and having --disable-thread-safety.

/Magnus


From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Thread safety
Date: 2008-11-27 09:37:48
Message-ID: 492E6A6C.4030905@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Magnus Hagander wrote:
> Can someone remind me why we have --enable-thread-safety? As opposed to
> it being default and having --disable-thread-safety.

I don't have any numbers or a roster to support this, but I suppose that
thread-safety is not supported on some platforms. So either we'd have
to have diverging defaults or annoy those unsupported platforms with a
mandatory switch. The situation is quite similar in my view to the
integer datetimes switch: we need a very high level of platform support
before turning this on by default.

(I suppose there was initially also some general uncertainty about the
maturity of thread things, but I think we can consider that satisfied by
now.)


From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Thread safety
Date: 2008-11-27 12:00:39
Message-ID: 20081127120039.GB4586@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Peter Eisentraut wrote:
> Magnus Hagander wrote:
>> Can someone remind me why we have --enable-thread-safety? As opposed to
>> it being default and having --disable-thread-safety.
>
> I don't have any numbers or a roster to support this, but I suppose that
> thread-safety is not supported on some platforms. So either we'd have
> to have diverging defaults or annoy those unsupported platforms with a
> mandatory switch.

We could try switching it for a day and see what happens to the
buildfarm ... that would give us an idea of how many platforms are not
prepared.

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support


From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Thread safety
Date: 2008-11-27 13:14:37
Message-ID: 6E3A838D-5D51-4460-8EB2-9351C7D9C876@hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 27 nov 2008, at 13.00, Alvaro Herrera <alvherre(at)commandprompt(dot)com>
wrote:

> Peter Eisentraut wrote:
>> Magnus Hagander wrote:
>>> Can someone remind me why we have --enable-thread-safety? As
>>> opposed to
>>> it being default and having --disable-thread-safety.
>>
>> I don't have any numbers or a roster to support this, but I suppose
>> that
>> thread-safety is not supported on some platforms. So either we'd
>> have
>> to have diverging defaults or annoy those unsupported platforms
>> with a
>> mandatory switch.
>
> We could try switching it for a day and see what happens to the
> buildfarm ... that would give us an idea of how many platforms are not
> prepared.
>
+1.

It would be very good to have it ok by default if we cab, and that
seems luke a good way to see if it's reasonable...

/Magnus


From: Andrew Chernow <ac(at)esilo(dot)com>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Thread safety
Date: 2008-11-27 13:43:32
Message-ID: 492EA404.5080806@esilo.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Magnus Hagander wrote:
> On 27 nov 2008, at 13.00, Alvaro Herrera <alvherre(at)commandprompt(dot)com>
> wrote:
>
>> Peter Eisentraut wrote:
>>> Magnus Hagander wrote:
>>>> Can someone remind me why we have --enable-thread-safety? As opposed to
>>>> it being default and having --disable-thread-safety.
>>>
>>> I don't have any numbers or a roster to support this, but I suppose that
>>> thread-safety is not supported on some platforms. So either we'd have
>>> to have diverging defaults or annoy those unsupported platforms with a
>>> mandatory switch.
>>
>> We could try switching it for a day and see what happens to the
>> buildfarm ... that would give us an idea of how many platforms are not
>> prepared.
>>
> +1.
>
> It would be very good to have it ok by default if we cab, and that seems
> luke a good way to see if it's reasonable...
>
> /Magnus
>

It would probably be useful to nail down the supported platforms, have a list
somewhere of the oldest ones: oldest solaris, hpux, irix, aix, sco, etc...

I ran into a few --enable-thread-safety problems, Magnus fixed the cygwin build
already. hpux 10.20 and solaris 2.5.1 were both broken. Sounds like there is
no interest in supporting hpux 10.20, not sure about solaris 2.5.1 realeased in
1996. I only discovered this trying to build libpqtypes, which requires libpq,
on our internal build farm.

--
Andrew Chernow
eSilo, LLC
every bit counts
http://www.esilo.com/


From: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>
To: Andrew Chernow <ac(at)esilo(dot)com>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Thread safety
Date: 2008-11-27 21:15:43
Message-ID: 492F0DFF.3020601@sun.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Andrew Chernow napsal(a):

>
> It would probably be useful to nail down the supported platforms, have a
> list somewhere of the oldest ones: oldest solaris, hpux, irix, aix, sco,
> etc...
>
> I ran into a few --enable-thread-safety problems, Magnus fixed the
> cygwin build already. hpux 10.20 and solaris 2.5.1 were both broken.
> Sounds like there is no interest in supporting hpux 10.20, not sure
> about solaris 2.5.1 realeased in 1996.

I don't think so that there is interest to fix it for solaris 2.5.1. Everything
older than Solaris 8 is not officially supported (exclude timezone updates which
are available for old systems) and Solaris 8 is in EOL mode.

Anyway solaris 2.5.1 runs only on old HW and I don't see any benefit to run new
PostgreSQL version on hardware with small harddisk and memory.

Zdenek