Re: [RFC,PATCH] SIGPIPE masking in local socket connections

From: Marko Kreen <markokr(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Jeremy Kerr <jk(at)ozlabs(dot)org>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [RFC,PATCH] SIGPIPE masking in local socket connections
Date: 2009-06-02 14:16:05
Message-ID: e51f66da0906020716y635bd2c1s49e8d91785c732bc@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 6/2/09, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Jeremy Kerr <jk(at)ozlabs(dot)org> writes:
>
> >> The consideration is that the application fails completely on server
> >> disconnect (because it gets SIGPIPE'd). This was long ago deemed
> >> unacceptable, and we aren't likely to change our opinion on that.
>
> > OK, understood. I'm guessing MSG_NOSIGNAL on the send() isn't portable
> > enough here?
>
>
> Well, it's certainly not 100% portable, but I wouldn't object to a patch
> that tests for it and uses it where it works.
>
> One question that might be a bit hard to answer is whether mere
> existence of the #define is sufficient evidence that the feature works.
> We've had problems before with userland headers not being in sync
> with what the kernel knows.

Well, we could just test in configure perhaps? Runtime test is also
possible (if kernel gives error on unknown flag). Safest would
be enable on known-good OSes, maybe with version check?

--
marko

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Markus Wanner 2009-06-02 14:23:33 Re: PostgreSQL Developer meeting minutes up
Previous Message Tom Lane 2009-06-02 14:11:11 Re: [RFC,PATCH] SIGPIPE masking in local socket connections