From: | "Hitoshi Harada" <umi(dot)tanuki(at)gmail(dot)com> |
---|---|
To: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | "Heikki Linnakangas" <heikki(dot)linnakangas(at)enterprisedb(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Is "Window" really safe as a global typedef name? |
Date: | 2008-12-21 04:35:07 |
Message-ID: | e08cc0400812202035o50b12793vc432d9d0aac75dde@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
2008/12/21 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:
> Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> writes:
>> Tom Lane wrote:
>>> So I'm thinking we'd better rename it, but I'm not coming up with
>>> anything good; the best I can do after a long day is "EvalWindow",
>>> and that doesn't seem particularly inspired. Any suggestions?
>
>> EvalWindow sounds like a function in src/backend/executor/.
>
>> WindowAgg?
>
> WindowAgg seems like a winner to me, because it draws a parallel to
> the regular Agg node type, which seems valid unless I've completely
> misunderstood what's happening...
I disagree with WindowAgg. The aggregates are subset of window
functions in the node, though much code is similar and ported from
nodeAgg.
The spec introduces its concept as "Windowed Table". So I'd suggest
"WindowedTable" or "WindowTable". Or "Windowed" if shortened.
Regards,
--
Hitoshi Harada
From | Date | Subject | |
---|---|---|---|
Next Message | Hitoshi Harada | 2008-12-21 05:10:10 | Re: Windowing Function Patch Review -> Standard Conformance |
Previous Message | Abhijit Menon-Sen | 2008-12-21 04:05:22 | Re: pg_dump roles support [Review] |