Re: CREATE TABLE LIKE INCLUDING INDEXES support

From: NikhilS <nikkhils(at)gmail(dot)com>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Neil Conway" <neilc(at)samurai(dot)com>, "Bruce Momjian" <bruce(at)momjian(dot)us>, "Trevor Hardcastle" <chizu(at)spicious(dot)com>, pgsql-patches(at)postgresql(dot)org
Subject: Re: CREATE TABLE LIKE INCLUDING INDEXES support
Date: 2007-05-03 05:59:52
Message-ID: d3c4af540705022259w588a76a3rdbd43897290553ae@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Hi,

On 5/3/07, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> NikhilS <nikkhils(at)gmail(dot)com> writes:
> > Hi Neil,
> >> * the patch is broken for expressional indexes, and silently omits
> >> copying the predicate that may be associated with an index.
>
> > Since this patch is only supposed to copy unique/primary indexes, I dont
> > think we will ever have predicates associated to such indexes?
>
> Huh? I would expect a clause "INCLUDING INDEXES" to mean copying *all*
> indexes. A clause "INCLUDING CONSTRAINTS" would reasonably act as you
> suggest, ie copy only indexes derived from SQL constraint clauses.

But this patch is not for the "INCLUDING INDEXES" case. As mentioned by
Bruce earlier in this thread, this patch is for the following TODO:

o Have WITH CONSTRAINTS also create constraint indexes
http://archives.postgresql.org/pgsql-patches/2007-04/msg00149.php

Regards,
Nikhils

regards, tom lane
>

--
EnterpriseDB http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2007-05-03 06:32:20 Re: CREATE TABLE LIKE INCLUDING INDEXES support
Previous Message Magnus Hagander 2007-05-03 05:50:41 Re: Optimization in convert_string_datum?

Browse pgsql-patches by date

  From Date Subject
Next Message Jaime Casanova 2007-05-03 06:28:11 [WIP] GUC for temp_tablespaces
Previous Message Neil Conway 2007-05-03 05:49:39 Re: CREATE TABLE LIKE INCLUDING INDEXES support