Re: Kudos for Reviewers -- straw poll

From: "Greg Sabino Mullane" <greg(at)turnstep(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Kudos for Reviewers -- straw poll
Date: 2013-06-27 20:39:02
Message-ID: cecc1fd0edccb91651daff86dcf58e86@biglumber.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


-----BEGIN PGP SIGNED MESSAGE-----
Hash: RIPEMD160

Josh Berkus wrote:

> I wasn't thinking about doing it every year -- just for 9.3, in order to
> encourage more reviewers, and encourage reviewers to do more reviews.

- -1. It's not cool to set it up and then stop it the next go round.

You want more reviewers? Start by streamlining the process as much as
possible. I pretended I was new to the project and tried to figure
out how to review something. The homepage has no mention of reviewers,
not even if you drill down on some subpages. A Google search does lead
one to:

http://wiki.postgresql.org/wiki/Reviewing_a_Patch

It has some good "you can do it" wordage. However, there is no clear path
on how to actually start reviewing. There is this paragraph with
two links in it:

"The current commitfest is here[1] and has plenty of room for
you to help. You can sign up to become a Round Robin
Reviewer here[2]. Once you have, write a mail to the list
introducing yourself."

[1] Leads to the commitfest, with a nice summary, but no way for new people
to know what to do.

[2] This link is even worse (http://www.postgresql.org/list/pgsql-rrreviewers/)
It's an archive list for pgsql-rrreviewers, with no way to subscribe
and certainly no indication on it or the previous page that "sign up"
means (one might guess) join the mailing list.

Anyway, just food for thought as far as attracting new people. It should
be much easier and more intuitive. As far as "rewarding" current reviewers,
put the names in the release notes, after each item. Full stop.

- --
Greg Sabino Mullane greg(at)turnstep(dot)com
End Point Corporation http://www.endpoint.com/
PGP Key: 0x14964AC8 201306271636
http://biglumber.com/x/web?pk=2529DF6AB8F79407E94445B4BC9B906714964AC8
-----BEGIN PGP SIGNATURE-----

iEYEAREDAAYFAlHMoqIACgkQvJuQZxSWSsgCPACgovKYtxJV59Xro0MlxPDEHIy6
pmAAoOLOAlpO/dPlJbyHypdcY4ZxLCit
=RwMh
-----END PGP SIGNATURE-----

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Josh Berkus 2013-06-27 21:12:29 Re: patch submission: truncate trailing nulls from heap rows to reduce the size of the null bitmap [Review]
Previous Message Bruce Momjian 2013-06-27 19:58:06 Re: updated emacs configuration