Re: Add pgbench option: CHECKPOINT before starting benchmark

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: KONDO Mitsumasa <kondo(dot)mitsumasa(at)lab(dot)ntt(dot)co(dot)jp>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add pgbench option: CHECKPOINT before starting benchmark
Date: 2013-08-30 08:34:39
Message-ID: alpine.DEB.2.02.1308301032100.14562@localhost6.localdomain6
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


> My patches option difinition is here.
> [mitsu-ko(at)localhost pgbench]$ ./pgbench --help
> ~
> -N, --no-checkpoint do not run CHECKPOINT after initialization
> ~
> In latest commited pgbench, -N is "--skip-some-updates skip updates of
> pgbench_tellers and pgbench_branches". But I cannot understand why -N is this
> option, so I set this option -u, and -N is "do not run CHECKPOINT option".
>
> What do you think?

Although I agree that the -N is not really meaningful, ISTM that changing
option names is to be avoided if people are used to it. In this instance,
I'm not sure that many people use this option, so maybe this is not an
issue.

The patch should also update the sgml documentation.

--
Fabien.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bjorn Munch 2013-08-30 09:01:23 Re: [9.3 doc fix] clarification of Solaris versions
Previous Message Cédric Villemain 2013-08-30 08:20:48 Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: Proposal for Allow postgresql.conf values to be changed via SQL [review])