| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Robins Tharakan <tharakan(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Patch to add regression tests for SCHEMA |
| Date: | 2013-07-17 08:47:52 |
| Message-ID: | alpine.DEB.2.02.1307171032020.3991@localhost6.localdomain6 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I've looked this version.
The only reservation I have is that when changing the owner of a schema,
the new owner is not always checked. I would suggest to query the new
owner to check that it matches (5, 11, 12), just as you do in 3.
Also, reowning is tested several times (5, 11, 12). I would suggest to
remove 12 which does not bring much new things after both 5 and 11 get
passed ?
Otherwise the patch applies (with a minor warning about spaces on line 33)
passes for me, and brings valuable new test coverage.
--
Fabien.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Smith | 2013-07-17 08:54:00 | Re: [PATCH] pgbench --throttle (submission 7 - with lag measurement) |
| Previous Message | Tatsuo Ishii | 2013-07-17 08:44:38 | Re: [PATCH] pgbench --throttle (submission 7 - with lag measurement) |