Re: New regression test time

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Andres Freund <andres(at)2ndquadrant(dot)com>
Cc: Josh Berkus <josh(at)agliodbs(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Robins Tharakan <tharakan(at)gmail(dot)com>
Subject: Re: New regression test time
Date: 2013-06-29 04:28:47
Message-ID: alpine.DEB.2.02.1306290623230.2808@localhost6.localdomain6
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


>>> How did you evaluate that coverage increased "greatly"? I am not
>>> generally against these tests but I'd be surprised if the overall test
>>> coverage improved noticeably by this. Which makes 10% runtime overhead
>>> pretty hefty if the goal is to actually achieve a high coverage.
>>
>> I was relying on Robins' numbers of coverage:
>
> Those improvements rather likely end up being an improvement a good bit
> less than one percent for the whole binary.

Yes, but it is a valuable percent nevertheless.

As I understand it, the coverage is about the tested command logic. A lot
this logic is dedicated to check permissions (can you add an operator to
this database? ...) and to verify required conditions (is the function
proposed for operator has the right signature? does the operator overwrite
an existing one? ...).

--
Fabien.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2013-06-29 04:36:36 Re: New regression test time
Previous Message Peter Eisentraut 2013-06-29 03:59:58 Re: [GENERAL] pg_upgrade -u