From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
---|---|
To: | Cédric Villemain <cedric(at)2ndquadrant(dot)com> |
Cc: | PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
Subject: | Re: [Review] Re: minor patch submission: CREATE CAST ... AS EXPLICIT |
Date: | 2013-06-22 20:09:12 |
Message-ID: | alpine.DEB.2.02.1306221856450.23902@localhost6.localdomain6 |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hello Cédric,
> So maybe it is possible to rephrase this piece:
> - <literal>AS IMPLICIT</> is a <productname>PostgreSQL</productname>
> - extension, too.
> + <literal>AS IMPLICIT</> and <literal>AS EXPLICIT</> are
> + a <productname>PostgreSQL</productname> extension, too.
Ok.
> Back in 2012 Tom exposed arguments against it, or at least not a clear +1.
> The patch add nothing but more explicit creation statement, it has gone
> untouched for 2 years without interest so it is surely not something really
> important for PostgreSQL users.
Elegant is important:-) See my answer to Robert's objection.
> * Coding review
> Patch does not pass test:
> ./check_keywords.pl gram.y ../../../src/include/parser/kwlist.h
Oops! That is not elegant!
> I had to update the unreserved keyword list in order to be able to build
> postgresql.
> ** Does it produce compiler warnings? don't build as is. Need patch update
Indeed.
> I flag it 'return with feedback', please update the patch so it builds.
> Everything else is ok.
Yep.
--
Fabien.
From | Date | Subject | |
---|---|---|---|
Next Message | Fabien COELHO | 2013-06-22 20:29:07 | Re: [Review] Re: minor patch submission: CREATE CAST ... AS EXPLICIT |
Previous Message | Fabien COELHO | 2013-06-22 19:55:37 | Re: [Review] Re: minor patch submission: CREATE CAST ... AS EXPLICIT |