Re: [COMMITTERS] pgsql: timestamptz_trunc() should only recalculate

From: Devrim GUNDUZ <devrim(at)gunduz(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)PostgreSQL(dot)org
Subject: Re: [COMMITTERS] pgsql: timestamptz_trunc() should only recalculate
Date: 2004-11-01 22:35:54
Message-ID: Pine.LNX.4.61.0411020030500.1926@emo.org.tr
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

I got an error in make check now, in horology test:

http://postgresql.gunduz.org/regression.diffs

Is it related to this commit?

Regards, Devrim
On Mon, 1 Nov 2004, Tom Lane wrote:

> Log Message:
> -----------
> timestamptz_trunc() should only recalculate the timezone when truncating
> to DAY precision or coarser; leave the timezone alone when precision is
> HOUR or less. This avoids surprises for inputs near a DST transition
> time, as per example from Matthew Gabeler-Lee. (The only reason we
> recalculate at all is so that outputs that are supposed to represent
> days will come out as local midnight, and that's not relevant for sub-day
> precision.)
>
> Modified Files:
> --------------
> pgsql/src/backend/utils/adt:
> timestamp.c (r1.113 -> r1.114)
> (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/timestamp.c.diff?r1=1.113&r2=1.114)
>
> ---------------------------(end of broadcast)---------------------------
> TIP 6: Have you searched our list archives?
>
> http://archives.postgresql.org
>

- --
Devrim GUNDUZ
devrim~gunduz.org devrim.gunduz~linux.org.tr
http://www.tdmsoft.com
http://www.gunduz.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQFBhrpMtl86P3SPfQ4RAvtXAKCs7zWA3n8crbd5VsToKoTobHqtEQCdEw5y
mU92XW7xTLm3iC3L+jq0idA=
=Rm7E
-----END PGP SIGNATURE-----

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Devrim GUNDUZ 2004-11-01 23:00:52 Re: [COMMITTERS] pgsql: timestamptz_trunc() should only
Previous Message Tom Lane 2004-11-01 22:00:39 pgsql: timestamptz_trunc() should only recalculate the timezone when

Browse pgsql-hackers by date

  From Date Subject
Next Message Devrim GUNDUZ 2004-11-01 23:00:52 Re: [COMMITTERS] pgsql: timestamptz_trunc() should only
Previous Message Thomas Hallgren 2004-11-01 22:30:49 Re: charset/collation in values