Re: [PATCHES] ALTER TABLE modifications

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Hannu Krosing <hannu(at)tm(dot)ee>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Rod Taylor <pg(at)rbt(dot)ca>, <pg(at)fastcrypt(dot)com>, PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCHES] ALTER TABLE modifications
Date: 2003-11-14 19:01:13
Message-ID: Pine.LNX.4.44.0311141956540.5327-100000@peter.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Hannu Krosing writes:

> > AFAICT, this patch does not buy us anything at all. It's just a different
> > spelling of existing functionality. We have never done that before.
>
> what about DROP COLUMN - this is also just a different spelling for
>
> SELECT INTO, migrate all constraints, DROP OLD TABLE, RENAME.

No, because DROP COLUMN preserves dependent objects.

> > We cannot possibly leave this patch as is. People expect in-place column
> > changes.
>
> Does SQL spec even require that SELECT * always returns columns in the
> same order ?

Yes:

b) Otherwise, the <select list> "*" is equivalent to a <value
expression> sequence in which each <value expression>
is a column reference that references a column of T and
each column of T is referenced exactly once. The columns
are referenced in the ascending sequence of their ordinal
position within T.

> I don't think that relational model assigns any 'order' to columns.

Correct, but SQL is not the relational model or vice versa.

> BTW, SELECT * is just a different spelling of existing functionality ;)

No, there is no other way to get a complete list of columns. (Hard-coding
does not count.)

--
Peter Eisentraut peter_e(at)gmx(dot)net

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2003-11-14 19:01:17 Re: 7.4RC2 regression failur and not running stats collector process
Previous Message Bruce Momjian 2003-11-14 18:52:32 Re: Background writer process

Browse pgsql-patches by date

  From Date Subject
Next Message Euler Taveira de Oliveira 2003-11-14 19:03:59 update for brazilian portuguese translation
Previous Message Tom Lane 2003-11-14 18:42:59 Re: ALTER TABLE modifications