From: | Kris Jurka <books(at)ejurka(dot)com> |
---|---|
To: | Patrick Higgins <phiggins(at)transzap(dot)com> |
Cc: | PostgreSQL JDBC <pgsql-jdbc(at)postgresql(dot)org> |
Subject: | Re: Patch for some bugs/annoyances |
Date: | 2003-12-12 01:45:18 |
Message-ID: | Pine.LNX.4.33.0312112044080.25411-200000@leary.csoft.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-jdbc |
On Thu, 11 Dec 2003, Patrick Higgins wrote:
> On Thu, 2003-12-11 at 14:32, Kris Jurka wrote:
> > On Thu, 11 Dec 2003, Patrick Higgins wrote:
> >
> > > This first bug may have been causing the second; I can't remember
> > > anymore. Anyway, sometimes this.state in PSQLException is null causing
> > > getSQLState() to throw a NullPointerException. I've included a check for
> > > this and return the string "null" when the state is null.
> > >
> >
> > I don't think returning "null" is correct. I think
> > PSQLState.UNKNOWN_STATE should be used as the state when it is null.
>
> That sounds like a much better idea. I only used "null" because I didn't
> know better.
>
Here's a patch to that effect. Also the Serializable part has already
been addressed.
Kris Jurka
Attachment | Content-Type | Size |
---|---|---|
missingsqlstate.patch | text/plain | 2.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Kris Jurka | 2003-12-12 02:06:42 | Re: JDBC function call (getting resultset) |
Previous Message | Dave Cramer | 2003-12-12 00:03:47 | Re: PostgreSQL & DB2 !!! |