| From: | Jeremy Drake <pgsql(at)jdrake(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, David Fetter <david(at)fetter(dot)org>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>, Neil Conway <neilc(at)samurai(dot)com>, Mark Dilger <pgsql(at)markdilger(dot)com> |
| Subject: | Re: patch adding new regexp functions |
| Date: | 2007-02-18 23:10:51 |
| Message-ID: | Pine.BSO.4.64.0702181508280.18849@resin.csoft.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
On Sun, 18 Feb 2007, Jeremy Drake wrote:
> On Sun, 18 Feb 2007, Peter Eisentraut wrote:
>
> > > regexp_split(string text, pattern text[, flags text]) returns setof
> > > text
> > >
> > > regexp_split_array(string text, pattern text[. flags text[, limit
> > > int]]) returns text[]
> >
> > Since you are not splitting an array but returning an array, I would
> > think that "regexp_split_to_array" would be better, and the other
> > should then be "regexp_split_to_table".
>
> OK
>
> > But why does the second one have a limit and the first one doesn't?
I will rename the functions regexp_split_to_(table|array) and I will add
an optional limit parameter to the regexp_split_to_table function, for
consistency and to avoid ordering concerns with LIMIT.
--
Sometimes I worry about being a success in a mediocre world.
-- Lily Tomlin
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2007-02-18 23:19:49 | TopPlan, again |
| Previous Message | Russell Smith | 2007-02-18 22:48:23 | Re: Plan invalidation design |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2007-02-18 23:27:11 | Re: patch adding new regexp functions |
| Previous Message | Jeremy Drake | 2007-02-18 20:03:35 | Re: patch adding new regexp functions |