Re: PATCH: CITEXT 2.0

From: "David E(dot) Wheeler" <david(at)kineticode(dot)com>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: PATCH: CITEXT 2.0
Date: 2008-07-07 18:47:23
Message-ID: F5ECEEC2-6AFE-499B-8DBE-65166E2E92EB@kineticode.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Jul 7, 2008, at 11:44, Alvaro Herrera wrote:

>> I'm confused. What's the difference between strncmp() and
>> varstr_cmp()?
>> And why would I use one in one place and the other elsewhere?
>> Shouldn't
>> they be used consistently?
>
> Not necessarily -- see texteq. I think the point is that varstr_cmp()
> is a lot slower.

Then why shouldn't I use strncmp() for all comparisons?

>> No, I was wondering before what locale was used for initdb on the
>> build
>> farm. I mean, how are locale-aware things really tested?
>
> They aren't AFAIK.

Ow. Pity.

Best,

David

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2008-07-07 18:54:02 Re: PATCH: CITEXT 2.0
Previous Message Alvaro Herrera 2008-07-07 18:44:32 Re: PATCH: CITEXT 2.0