From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Don't pay heed to wal_sender_timeout while creating a decoding s |
Date: | 2014-05-28 22:33:06 |
Message-ID: | E1WpmPC-0006lE-5Y@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Don't pay heed to wal_sender_timeout while creating a decoding slot.
Sometimes CREATE_REPLICATION_SLOT ... LOGICAL ... needs to wait for
further WAL using WalSndWaitForWal(). That used to always respect
wal_sender_timeout and kill the session when waiting long enough
because no feedback/ping messages can be sent while the slot is still
being created.
Introduce the notion that last_reply_timestamp = 0 means that the
walsender currently doesn't need timeout processing to avoid that
problem. Use that notion for CREATE_REPLICATION_SLOT ... LOGICAL.
Bugreport and initial patch by Steve Singer, revised by me.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/21d48d66c8be053ef5ce0474bb30f8a91b7c3dd6
Modified Files
--------------
src/backend/replication/walsender.c | 31 ++++++++++++++++++++++++++-----
1 file changed, 26 insertions(+), 5 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2014-05-28 22:36:40 | Re: pgsql: Reset master xmin when hot_standby_feedback disabled. |
Previous Message | Andres Freund | 2014-05-28 21:27:21 | Re: pgsql: Fix bogus %name-prefix option syntax in all our Bison files. |