pgsql: Fix bogus time printout in walreceiver's debug log messages.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix bogus time printout in walreceiver's debug log messages.
Date: 2014-04-04 15:44:25
Message-ID: E1WW6I5-0002mk-Ue@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix bogus time printout in walreceiver's debug log messages.

The displayed sendtime and receipttime were always exactly equal, because
somebody forgot that timestamptz_to_str returns a static buffer (thereby
simplifying life for most callers, at the cost of complicating it for those
who need two results concurrently). Apply the same pstrdup solution used
by the other call sites with this issue. Back-patch to 9.2 where the
faulty code was introduced. Per bug #9849 from Haruka Takatsuka, though
this is not exactly his patch.

Possibly we should change timestamptz_to_str's API, but I wouldn't want
to do so in the back branches.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/8120c7452a51a773ad7a249b55557439f39d41ef

Modified Files
--------------
src/backend/replication/walreceiver.c | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2014-04-04 15:44:26 pgsql: Fix bogus time printout in walreceiver's debug log messages.
Previous Message Robert Haas 2014-04-04 15:33:14 pgsql: Fix some compiler warnings that clang emits with -pedantic.