From: | "MauMau" <maumau307(at)gmail(dot)com> |
---|---|
To: | "Michael Paquier" <michael(dot)paquier(at)gmail(dot)com>, "PostgreSQL mailing lists" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Removing dependency to wsock32.lib when compiling code on WIndows |
Date: | 2014-06-18 11:37:00 |
Message-ID: | E1C53B6ABEEB452DB16DE8FDFEC79BA6@maumau |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
From: "Michael Paquier" <michael(dot)paquier(at)gmail(dot)com>
> When doing some work on Windows, I noticed that the mkvc specs in
> src/tools/msvc use wsock32.lib, which is as far as I understand an
> old, obsolete version of the Windows socket library. Wouldn't it make
> sense to update the specs to build only with ws2_32.lib like in the
> patch attached?
Yes, that makes sense, because wsock32.dll is an obsolete WinSock 1.1
library, while ws2_32.dll is a successor WinSock 2.0 library which is fully
compatible with the old one.
Doing "grep -lir wsock32 ." shows the following files. Could you modify and
test these files as well for code cleanup?
./configure
./configure.in
./contrib/pgcrypto/Makefile
./src/interfaces/libpq/Makefile
./src/interfaces/libpq/win32.c
./src/interfaces/libpq/win32.mak
./src/test/thread/README
./src/tools/msvc/Mkvcbuild.pm
Regards
MauMau
From | Date | Subject | |
---|---|---|---|
Next Message | Stephen Frost | 2014-06-18 11:48:56 | Re: btreecheck extension |
Previous Message | Andres Freund | 2014-06-18 10:53:31 | Re: Minmax indexes |