Re: [PATCHES] Solve a problem of LC_TIME of windows.

From: "Hiroshi Saito" <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp>
To: "Hiroshi Inoue" <inoue(at)tpf(dot)co(dot)jp>
Cc: "pgsql-hackers" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCHES] Solve a problem of LC_TIME of windows.
Date: 2008-11-26 05:24:55
Message-ID: DE949CF046E94851A58B0662D10E310A@HIRO57887DE653
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Hi.

I think that MinGW does not have a direct relation.
#define_UNICODE is required for wcsftime.
Probably, ITAGAKI-san has only forgotten it.:-)

P.S)
日本語になっていましたです:-)

Regards,
Hiroshi Saito

----- Original Message -----
From: "Hiroshi Inoue" <inoue(at)tpf(dot)co(dot)jp>

> 井上です。
>
> ITAGAKI Takahiro wrote:
>> "Hiroshi Saito" <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp> wrote:
>>
>>> Um, It was not supported.
>>> http://winpg.jp/~saito/pg_work/LC_MESSAGE_CHECK/LC_TIME_PATCH/ITAGAKI_PATCH.txt
>>
>> Hmm... the implementation of wcsftime() in msvcrt seems to be
>> completely broken.
>>
>> I ran the attached test (localetest.c) and got the following results.
>> The point is that wcsftime() returns the same character codes as strftime()
>> i.e, the result is not an unicode string :-(
>>
>> The bug might be fixed in recently msvcrts in VC2005 or VC2008,
>> but at least mingw uses the old broken C runtime.
>
> 私はmingwを使っていないのでよくわからないのですが、ランタイムも一緒に
> 提供しているのですか?
>
>> We'd better to
>> use strftime() and multiple conversions to avoid the Microsoft's bug.
>
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Hitoshi Harada 2008-11-26 06:03:38 Re: Windowing Function Patch Review -> Standard Conformance
Previous Message Hiroshi Inoue 2008-11-26 05:10:58 Re: [PATCHES] Solve a problem of LC_TIME of windows.

Browse pgsql-patches by date

  From Date Subject
Next Message ITAGAKI Takahiro 2008-11-26 08:22:16 Re: [PATCHES] Solve a problem of LC_TIME of windows.
Previous Message Hiroshi Inoue 2008-11-26 05:10:58 Re: [PATCHES] Solve a problem of LC_TIME of windows.