Compiler warnings with stringRelOpts (was WIP: Fast GiST index build)

From: Alexander Korotkov <aekorotkov(at)gmail(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Compiler warnings with stringRelOpts (was WIP: Fast GiST index build)
Date: 2011-08-08 10:27:33
Message-ID: CAPpHfdvLWtPxNCUcAYNEON3mrABO31=iE0Rh4=Rr_Qc7qYM_cg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

String-formatted relopts was never used before, but I've used it in
buffering GiST index build patch and encountered with following compiler
warnings:

reloptions.c:259: warning: initializer-string for array of chars is too long
reloptions.c:259: warning: (near initialization for
‘stringRelOpts[0].default_val’**)

It is caused by definition of default field of relopt_string structure as
1-length character array. This seems to be a design flaw in the reloptions.c
code. Any thoughts?

------
With best regards,
Alexander Korotkov.

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Anssi Kääriäinen 2011-08-08 11:05:17 Re: Transient plans versus the SPI API
Previous Message Alexander Korotkov 2011-08-08 10:18:35 Re: WIP: Fast GiST index build