Re: Review: query result history in psql

From: ian link <ian(at)ilink(dot)io>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Cc: Maciej Gajewski <maciej(dot)gajewski0(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Review: query result history in psql
Date: 2013-07-01 01:19:02
Message-ID: CAOOwM5Lxvj=VnROxq_7Y_Y+7YFwiUtVzrurUHF3DN9JD0Q0Jhg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Not sure about all of your suggestions. Let me see if I can clarify what
you're looking for.

> * simply decision if content should be stored in history or not,

Do you mean that the user should use a flag to place the result of a query
into the history?
like:
--ans SELECT * FROM cities...
Not sure if that's what you mean, but it seems kind of unnecesary. They can
just hit the \ans flag beforehand.

* simply remove last entry (table) of history

That could be useful. What do you think Maciej?

* queries should be joined to content, only name is not enough

Don't know what you mean. Could you try re-wording that?

Ian

On Fri, Jun 28, 2013 at 8:49 AM, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>wrote:

> Hello
>
> I am not sure, this interface is really user friendly
>
> there is not possible "searching" in history, and not every query push
> to history some interesting content.
>
> It require:
>
> * simply decision if content should be stored in history or not,
> * simply remove last entry (table) of history
> * queries should be joined to content, only name is not enough
>
> Regards
>
> Pavel
>
> 2013/6/28 Maciej Gajewski <maciej(dot)gajewski0(at)gmail(dot)com>:
> > Thanks for checking the patch!
> >
> > So what's left to fix?
> > * Moving the escaping-related functions to separate module,
> > * applying your corrections.
> >
> > Did I missed anything?
> >
> > I'll submit corrected patch after the weekend.
> >
> > M
> >
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jon Nelson 2013-07-01 01:28:11 Re: fallocate / posix_fallocate for new WAL file creation (etc...)
Previous Message David Fetter 2013-07-01 01:00:35 Re: Review: UNNEST (and other functions) WITH ORDINALITY