Re: pg_xlogdump

From: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Andres Freund <andres(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_xlogdump
Date: 2013-02-23 22:54:51
Message-ID: CAMkU=1yX6QBnPoneoHxWQdQS0PzH5Xe_Zyce-X742OC4OQnJ6g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Feb 22, 2013 at 11:58 AM, Alvaro Herrera
<alvherre(at)2ndquadrant(dot)com>wrote:

> Andres Freund wrote:
> > On 2013-02-13 12:09:37 -0300, Alvaro Herrera wrote:
> > > Here's an updated version of pg_xlogdump. This is rebased on top of
> the
> > > committed xlogreader, palloc restructuring and libpgcommon, PG_RMGR
> > > stuff, and is basically a revamped version of what Andres submitted in
> > >
> http://www.postgresql.org/message-id/1357672187-7693-5-git-send-email-andres@2ndquadrant.com
> >
> > Two tiny followup bits, I had fixed since:
> > * one copy-and-paste-o in an error message
> > * replace stupid directory verification implementation
> > * fix include in compat.c to include utils/timestamp.h instead of
> > datatype/
>
> Applied with some additional fixes.
>

Hi Álvaro,

If I run "make clean", or "make maintainer-clean", this deletes the file
contrib/pg_xlogdump/rmgrdesc.c. And then config/make doesn't know how to
get it back again.

I don't know if the Makefile needs to be taught not to delete it, or taught
how to recreate it once deleted.

Thanks,

Jeff

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jov 2013-02-24 00:33:34 Re: make: *** pg_xlogdump: No such file or directory. Stop.
Previous Message Pavel Stehule 2013-02-23 21:51:31 Re: BUG #7873: pg_restore --clean tries to drop tables that don't exist