Re: [PATCH 03/14] Add simple xlogdump tool

On Thu, Nov 15, 2012 at 9:13 AM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
> On 2012-11-15 09:06:23 -0800, Jeff Janes wrote:
>> On Wed, Nov 14, 2012 at 5:17 PM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
>> > ---
>> > src/bin/Makefile | 2 +-
>> > src/bin/xlogdump/Makefile | 25 +++
>> > src/bin/xlogdump/xlogdump.c | 468 ++++++++++++++++++++++++++++++++++++++++++++
>> > 3 files changed, 494 insertions(+), 1 deletion(-)
>> > create mode 100644 src/bin/xlogdump/Makefile
>> > create mode 100644 src/bin/xlogdump/xlogdump.c
>>
>> Is this intended to be the successor of
>> https://github.com/snaga/xlogdump which will then be deprecated?
>
> As-is this is just a development tool which was sorely needed for the
> development of this patchset. But yes I think that once ready
> (xlogreader infrastructure, *_desc routines splitted) it should
> definitely be able to do most of what the above xlogdump can do and it
> should live in bin/. I think mostly some filtering is missing.
>
> That doesn't really "deprecate" the above though.
>
> Does that answer your question?

Yes, I think so. Thanks.

(I've just recently gotten the original xlogdump to work for me in
9.2, and I had been wonder if back-porting yours to 9.2 would have
been an easier way to go.)

Cheers,

Jeff