Re: PITR potentially broken in 9.2

On Sat, Dec 1, 2012 at 1:56 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Jeff Janes <jeff(dot)janes(at)gmail(dot)com> writes:
>> On Sat, Dec 1, 2012 at 12:47 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> Jeff Janes <jeff(dot)janes(at)gmail(dot)com> writes:
>>>> In the newly fixed 9_2_STABLE, that problem still shows up the same as
>>>> it does in 9.1.6.
>
>>> I tried to reproduce this as per your directions, and see no problem in
>>> HEAD. Recovery advances to the specified stop time, hot standby mode
>>> wakes up,
>
>> Hot standby should only wake up once recovery has proceeded beyond the
>> pg_stop_backup() point.
>
>> If the specified stop point is after pg_start_backup() finishes, but
>> before pg_stop_backup(), then hot standby should not start up (and
>> with the newest HEAD, in my hands, it does not). Are you sure you set
>> the stop time to just after pg_start_backup, not to just after
>> pg_stop_backup?
>
> I'm confused. Are you now saying that this problem only exists in
> 9.1.x? I tested current HEAD because you indicated the problem was
> still there.

No, I'm saying the problem exists both in 9.1.x and in hypothetical
9.2.2 and in hypothetical 9.3, but not in 9.2.[01] because in those it
is masked by that other problem which has just been fixed.

I'll try it again in b1346822f3048ede254647f3a46 just to be sure, but
I'm already fairly sure.

Cheers,

Jeff