From: | Peter Geoghegan <pg(at)heroku(dot)com> |
---|---|
To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: jsonb and nested hstore |
Date: | 2014-02-27 00:17:24 |
Message-ID: | CAM3SWZT8sOiC_qWgLR0pRGDqWVgwjLAi59qnve-HD6fNvgbHjQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Feb 26, 2014 at 2:10 PM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> new patch attached, change pushed to github.
> + /* GUC variables */
> + static bool pretty_print_var = false;
> + #define SET_PRETTY_PRINT_VAR(x) ((pretty_print_var) ? \
> + ((x) | PrettyPrint) : (x))
I think that this is not a great idea. I think that we should do away
with the GUC, but keep the function hstore_print() so we can pretty
print that way. I don't believe that this falls afoul of the usual
obvious reasons for not varying the behavior of IO routines with a
GUC, since it only varies whitespace, but it is surely pretty
questionable to have this GUC's setting vary the output of hstore_out,
an IMMUTABLE function.
--
Peter Geoghegan
From | Date | Subject | |
---|---|---|---|
Next Message | Kouhei Kaigai | 2014-02-27 00:25:17 | Re: Custom Scan APIs (Re: Custom Plan node) |
Previous Message | Andrew Dunstan | 2014-02-27 00:12:05 | Re: jsonb and nested hstore |