| From: | Peter Geoghegan <pg(at)heroku(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Josh Berkus <josh(at)agliodbs(dot)com>, Ian Barwick <ian(at)2ndquadrant(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, Greg Stark <stark(at)mit(dot)edu>, Jim Nasby <jim(at)nasby(dot)net>, Albe Laurenz <laurenz(dot)albe(at)wien(dot)gv(dot)at> |
| Subject: | Re: Doing better at HINTing an appropriate column within errorMissingColumn() |
| Date: | 2014-11-11 06:29:37 |
| Message-ID: | CAM3SWZSY0kr4brEncz30iUagfynKg=POo1TSwRXT8oOYUCWCJg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Nov 10, 2014 at 8:13 PM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> Hm. The last version of this patch has not really changed since since my
> first review, and I have no more feedback to provide about it except what I
> already mentioned. I honestly don't think that this patch is ready for
> committer as-is... If someone wants to review it further, well extra
> opinions I am sure are welcome.
Why not?
You've already said that you're happy to defer to whatever committer
picks this up with regard to whether or not more than a single
suggestion can come from an RTE. I agreed with this (i.e. I said I'd
defer to their opinion too), and once again drew particular attention
to this state of affairs alongside my most recent revision.
What does that leave?
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Josh Berkus | 2014-11-11 06:48:32 | Missing line for postgresql.auto.conf? |
| Previous Message | Michael Paquier | 2014-11-11 05:54:47 | Re: [GSoC2014] Patch ALTER TABLE ... SET LOGGED |