| From: | Peter Geoghegan <pg(at)heroku(dot)com> |
|---|---|
| To: | Ian Barwick <ian(at)2ndquadrant(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Josh Berkus <josh(at)agliodbs(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, Greg Stark <stark(at)mit(dot)edu>, Jim Nasby <jim(at)nasby(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Albe Laurenz <laurenz(dot)albe(at)wien(dot)gv(dot)at> |
| Subject: | Re: Doing better at HINTing an appropriate column within errorMissingColumn() |
| Date: | 2014-06-17 02:57:01 |
| Message-ID: | CAM3SWZRvoMM22ANS6JopneNtDccttntn_OygzkA+ymgLRrLF9w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jun 16, 2014 at 7:09 PM, Ian Barwick <ian(at)2ndquadrant(dot)com> wrote:
> Howver in this particular use case, as long as it doesn't produce false
> positives (I haven't looked at the patch) I don't think it would cause
> any problems (of the kind which would require actively excluding certain
> languages/character sets), it just wouldn't be quite as useful.
I'm not sure what you mean by false positives. The patch just shows a
HINT, where before there was none. It's possible for any number of
reasons that it isn't the most useful possible suggestion, since
Levenshtein distance is used as opposed to any other scheme that might
be better sometimes. I think that the hint given is a generally useful
piece of information in the event of an ERRCODE_UNDEFINED_COLUMN
error. Obviously I think the patch is worthwhile, but fundamentally
the HINT given is just a guess, as with the existing HINTs.
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ian Barwick | 2014-06-17 03:38:15 | Re: Doing better at HINTing an appropriate column within errorMissingColumn() |
| Previous Message | Abhijit Menon-Sen | 2014-06-17 02:24:53 | Re: Audit of logout |