| From: | Peter Geoghegan <pg(at)heroku(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: checksum_impl.h fails cpluspluscheck |
| Date: | 2013-06-30 04:44:04 |
| Message-ID: | CAM3SWZRa8J1zk1C6hghiXXKTy+r1KevPDBzTR1245uC_O7bvbg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Jun 29, 2013 at 8:55 PM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> ./src/include/storage/checksum_impl.h: In function ‘uint32 pg_checksum_block(char*, uint32)’:
> ./src/include/storage/checksum_impl.h:154: warning: comparison between signed and unsigned integer expressions
On the subject of checksum_impl.h, don't you think it's a bit
unfortunate that clients have to do this?:
+ // checksum_impl.h uses Assert, which doesn't work outside the server
+ #undef Assert
+ #define Assert(X)
+
+ #include "storage/checksum_impl.h"
+
Maybe external utilities ought to include another header that does all
of this for them?
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2013-06-30 05:29:20 | Re: pg_ctl and -h/help |
| Previous Message | Tom Lane | 2013-06-30 04:03:59 | Re: checksum_impl.h fails cpluspluscheck |